Github user mxmrlv commented on a diff in the pull request:

    https://github.com/apache/incubator-ariatosca/pull/84#discussion_r108393478
  
    --- Diff: aria/modeling/relationship.py ---
    @@ -114,28 +105,24 @@ def one_to_many_self(model_class,
         :param dict_key: If set the value will be a dict with this key as the 
dict key; otherwise will
                          be a list
         :type dict_key: basestring
    -    :param relationship_kwargs: Extra kwargs for SQLAlchemy 
``relationship``
    -    :type relationship_kwargs: {}
         """
    -
    -    relationship_kwargs = relationship_kwargs or {}
    -
    -    relationship_kwargs.setdefault('remote_side', 
'{model_class}.{remote_column}'.format(
    -        model_class=model_class.__name__,
    -        remote_column=fk
    -    ))
    -
    -    return _relationship(model_class, model_class.__tablename__, None, 
relationship_kwargs,
    -                         other_property=False, dict_key=dict_key)
    +    return _relationship(
    +        model_class,
    +        model_class.__tablename__,
    +        relationship_kwargs={
    +            'remote_side': '{model_class}.{remote_column}'.format(
    +                model_class=model_class.__name__, remote_column=fk)
    +        },
    +        back_populates=False,
    +        dict_key=dict_key
    +    )
     
     
     def one_to_one(model_class,
                    other_table,
                    fk=None,
                    other_fk=None,
    -               other_property=None,
    -               relationship_kwargs=None,
    -               backref_kwargs=None):
    +               back_populates=None):
    --- End diff --
    
    add NO_BACK_POP const (instead of False)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to