Github user ran-z commented on a diff in the pull request:
https://github.com/apache/incubator-ariatosca/pull/95#discussion_r111152020
--- Diff: aria/modeling/service_instance.py ---
@@ -1685,12 +1725,31 @@ def inputs(cls):
# endregion
description = Column(Text)
+ relationship_edge = Column(Boolean)
implementation = Column(Text)
+ configuration = Column(modeling_types.StrictDict(key_cls=basestring))
dependencies = Column(modeling_types.StrictList(item_cls=basestring))
executor = Column(Text)
max_retries = Column(Integer)
retry_interval = Column(Integer)
+ def configure(self):
+ from . import models
+ if (self.implementation is None) or (self.interface is None):
+ return
+
+ if self.plugin is None:
+ arguments = configure_operation(self)
--- End diff --
please use `execution_plugin.instantiation.configure_operation` or so,
there are enough `configure_operation` calls in this module as it is and it's
easily confusing :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
