Github user ran-z commented on a diff in the pull request:

    https://github.com/apache/incubator-ariatosca/pull/95#discussion_r111169192
  
    --- Diff: aria/modeling/service_template.py ---
    @@ -1848,11 +1856,30 @@ def as_raw(self):
     
         def instantiate(self, container):
             from . import models
    +        from ..orchestrator import context
    +        plugin = None
    +        if self.plugin_specification is not None:
    --- End diff --
    
    I'm not sure I understand this section.
    Operations are instantiated at service creation time. No workflow context 
should be available at this time.
    If a storage model object is required, it should be passed into the 
instantiate module directly (the current interface is problematic as is, and 
I've already broken it on the CLI branch in order to pass inputs to service 
template's instantiate), not taken off some thread local context.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to