Github user ran-z commented on a diff in the pull request:

    https://github.com/apache/incubator-ariatosca/pull/95#discussion_r111367441
  
    --- Diff: aria/modeling/service_template.py ---
    @@ -1848,11 +1856,30 @@ def as_raw(self):
     
         def instantiate(self, container):
             from . import models
    +        from ..orchestrator import context
    +        plugin = None
    +        if self.plugin_specification is not None:
    --- End diff --
    
    I understand and I have seen the comment, but I'm saying the changes I've 
mentioned need to happen now, not after we have the instantiation module.
    More so, I don't understand how this is expected to work anyway, as no 
execution context is expect to be present at the time this method is called.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to