Github user mxmrlv commented on a diff in the pull request:
https://github.com/apache/incubator-ariatosca/pull/104#discussion_r112406038
--- Diff: aria/cli/commands/executions.py ---
@@ -144,17 +144,17 @@ def start(workflow_name,
logger.info('Starting {0}execution. Press Ctrl+C cancel'.format('dry '
if dry else ''))
execution_thread.start()
- log_consumer = cli_logger.ModelLogConsumer(model_storage,
workflow_runner.execution_id)
+ log_iterator = cli_logger.ModelLogIterator(model_storage,
workflow_runner.execution_id)
try:
while execution_thread.is_alive():
- for log in log_consumer:
- execution_logging.load(log).log()
+ execution_logging.drain(log_iterator)
except KeyboardInterrupt:
_cancel_execution(workflow_runner, execution_thread, logger)
- for log in log_consumer:
- execution_logging.load(log).log()
+ # It might be the case where some logs were written and the execution
was terminated, thus we
+ # need to drain the remaining logs.
+ execution_logging.drain(log_iterator)
--- End diff --
177 : add logging
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
