[ 
https://issues.apache.org/jira/browse/ARIA-138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15976431#comment-15976431
 ] 

ASF GitHub Bot commented on ARIA-138:
-------------------------------------

Github user mxmrlv commented on a diff in the pull request:

    https://github.com/apache/incubator-ariatosca/pull/104#discussion_r112406038
  
    --- Diff: aria/cli/commands/executions.py ---
    @@ -144,17 +144,17 @@ def start(workflow_name,
         logger.info('Starting {0}execution. Press Ctrl+C cancel'.format('dry ' 
if dry else ''))
         execution_thread.start()
     
    -    log_consumer = cli_logger.ModelLogConsumer(model_storage, 
workflow_runner.execution_id)
    +    log_iterator = cli_logger.ModelLogIterator(model_storage, 
workflow_runner.execution_id)
         try:
             while execution_thread.is_alive():
    -            for log in log_consumer:
    -                execution_logging.load(log).log()
    +            execution_logging.drain(log_iterator)
     
         except KeyboardInterrupt:
             _cancel_execution(workflow_runner, execution_thread, logger)
     
    -    for log in log_consumer:
    -        execution_logging.load(log).log()
    +    # It might be the case where some logs were written and the execution 
was terminated, thus we
    +    # need to drain the remaining logs.
    +    execution_logging.drain(log_iterator)
    --- End diff --
    
    177 : add logging


> CLI output verbosity levels
> ---------------------------
>
>                 Key: ARIA-138
>                 URL: https://issues.apache.org/jira/browse/ARIA-138
>             Project: AriaTosca
>          Issue Type: Story
>            Reporter: Maxim Orlov
>            Assignee: Maxim Orlov
>
> The CLI should support the display of the following logging levels:
> default: execution logs: simple representation of executed operations
> -v      : execution logs: representation with time stamps and logging levels
> -vv    : execution logs: retrieve the stacktrace of any failed operation.
> -vvv  : all configured loggers should be set to {{debug}} level; any CLI 
> errors should be logged and printed with their stack trace as well.
> (both the default and the first level of logging format should be 
> configurable). 
> Note that all of the operations logs should be saved in the storage. This 
> issue relates only to the way the logs are displayed in the CLI.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to