[ 
https://issues.apache.org/jira/browse/ARIA-163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15996646#comment-15996646
 ] 

ASF GitHub Bot commented on ARIA-163:
-------------------------------------

Github user mxmrlv commented on a diff in the pull request:

    https://github.com/apache/incubator-ariatosca/pull/117#discussion_r114760148
  
    --- Diff: aria/orchestrator/workflows/api/task.py ---
    @@ -72,63 +72,43 @@ def __init__(self,
             Do not call this constructor directly. Instead, use 
:meth:`for_node` or
             :meth:`for_relationship`.
             """
    -
    -        actor_type = type(actor).__name__.lower()
             assert isinstance(actor, (models.Node, models.Relationship))
    -        assert actor_type in ('node', 'relationship')
    -        assert interface_name and operation_name
             super(OperationTask, self).__init__()
    -
             self.actor = actor
    -        self.max_attempts = (self.workflow_context._task_max_attempts
    -                             if max_attempts is None else max_attempts)
    -        self.retry_interval = (self.workflow_context._task_retry_interval
    -                               if retry_interval is None else 
retry_interval)
    -        self.ignore_failure = (self.workflow_context._task_ignore_failure
    -                               if ignore_failure is None else 
ignore_failure)
             self.interface_name = interface_name
             self.operation_name = operation_name
    -        self.name = OperationTask.NAME_FORMAT.format(type=actor_type,
    +        self.max_attempts = max_attempts or 
self.workflow_context._task_max_attempts
    +        self.retry_interval = retry_interval or 
self.workflow_context._task_retry_interval
    +        self.ignore_failure = ignore_failure or 
self.workflow_context._task_ignore_failure
    --- End diff --
    
    revert


> Update node state for stub tasks
> --------------------------------
>
>                 Key: ARIA-163
>                 URL: https://issues.apache.org/jira/browse/ARIA-163
>             Project: AriaTosca
>          Issue Type: Story
>    Affects Versions: 0.1.0
>            Reporter: Maxim Orlov
>            Assignee: Maxim Orlov
>
> Currently each node that has no implementation for an operation, has its 
> operations labeled a stub tasks. Those stub tasks aren't run through the 
> normal path of the workflow engine, and thus no update to the state of the 
> node is being done. this should be fixed 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to