[ https://issues.apache.org/jira/browse/ARIA-157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16004838#comment-16004838 ]
ASF GitHub Bot commented on ARIA-157: ------------------------------------- GitHub user AviaE opened a pull request: https://github.com/apache/incubator-ariatosca/pull/131 ARIA-157 Failing CLI service-templates store tests on Windows Three tests from `aria service-templates store` failed on Windows, but not on Linux. The reason for this failures was differing implementation of os.path.dirname across the platforms. Python implements os.path.dirname in the ntpath module. There, somewhere down the line of calls, (a part of) the argument of dirname is tested for membership in a string (using `in`). In these three tests, the argument of dirname is of type MagicMock, and an error is raised since only a string can be tested for membership in a string. The solution was to mock the dirname calls. You can merge this pull request into a Git repository by running: $ git pull https://github.com/apache/incubator-ariatosca ARIA-157-cli-service-template-store-tests-fail-in-windows Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-ariatosca/pull/131.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #131 ---- commit 6864d42e1748b5cd8ecc596fc1b4adc04b0cc9ba Author: Avia Efrat <a...@gigaspaces.com> Date: 2017-05-10T14:39:49Z ARIA-157 Failing CLI service-templates store tests on Windows Three tests from `aria service-templates store` failed on Windows, but not on Linux. The reason for this failures was differing implementation of os.path.dirname across the platforms. Python implements os.path.dirname in the ntpath module. There, somewhere down the line of calls, (a part of) the argument of dirname is tested for membership in a string (using `in`). In these three tests, the argument of dirname is of type MagicMock, and an error is raised since only a string can be tested for membership in a string. The solution was to mock the dirname calls. ---- > CLI unit tests for storing service-templates fail on appveyor > ------------------------------------------------------------- > > Key: ARIA-157 > URL: https://issues.apache.org/jira/browse/ARIA-157 > Project: AriaTosca > Issue Type: Bug > Reporter: Avia Efrat > Assignee: Avia Efrat > > The failing tests are: > test_store_no_exception > test_store_raises_exception_resulting_from_name_uniqueness > test_store_raises_exception > They pass on Travis. -- This message was sent by Atlassian JIRA (v6.3.15#6346)