Github user ran-z commented on a diff in the pull request:
https://github.com/apache/incubator-ariatosca/pull/107#discussion_r115934648
--- Diff: aria/cli/core/aria.py ---
@@ -325,6 +339,46 @@ def __init__(self):
default=defaults.SERVICE_TEMPLATE_FILENAME,
help=helptexts.SERVICE_TEMPLATE_FILENAME)
+ self.show_full = click.option(
+ '-f',
+ '--full',
+ 'mode',
+ is_flag=True,
+ flag_value='full',
--- End diff --
I think I don't like this approach as much at the previous one.
It seems like it simplifies the code a bit but makes things somewhat more
confusing to the user - specifically the fact that only the last flag of a
given "destination" (e.g. `mode`) takes hold.
If instead you have different destinations for these flags, it'd be easier
to inform the user of misuse (even if for some reason the mutually-exclusive
mechanism is problematic to use, you can always just manually validate the
parameters in the command function itself)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
