[
https://issues.apache.org/jira/browse/ARIA-171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16010361#comment-16010361
]
ASF GitHub Bot commented on ARIA-171:
-------------------------------------
GitHub user AviaE opened a pull request:
https://github.com/apache/incubator-ariatosca/pull/132
ARIA-171 service_template.services type inconsistency
As opposed to service_template.node_templates and service.nodes
which have a dict interface, service_template.services
had a list interface. That seemed as inconsistent, so the former
interface was changed to a dict interface as well.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/incubator-ariatosca
ARIA-171-service-template-services-type-inconsistency
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-ariatosca/pull/132.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #132
----
commit 4425c10306517cffce930b3f81623f350a116fae
Author: Avia Efrat <[email protected]>
Date: 2017-05-15T11:26:34Z
ARIA-171 service_template.services type inconsistency
As opposed to service_template.node_templates and service.nodes
which have a dict interface, service_template.services
had a list interface. That seemed as inconsistent, so the former
interface was changed to a dict interface as well.
----
> Service_template.services type inconsistency
> --------------------------------------------
>
> Key: ARIA-171
> URL: https://issues.apache.org/jira/browse/ARIA-171
> Project: AriaTosca
> Issue Type: Bug
> Reporter: Ran Ziv
> Assignee: Avia Efrat
>
> {{service_template.services}} is an object of type {{InstrumentedList}},
> which is inconsistent with similar forms of model access (e.g.
> {{service.nodes}}).
> The object's type should instead be a {{MappedCollection}} from the service
> name to the service model object.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
