Hi Ran,

I fixed those issues. I have commited those with changes , am not sure if I 
have to make another PR ?
Could you please advice me here ?


Regards,
DJ

-----Original Message-----
From: Ran Ziv [mailto:r...@gigaspaces.com] 
Sent: Friday, July 07, 2017 3:28 PM
To: dev@ariatosca.incubator.apache.org
Subject: Re: Missing support for type qualified name

Hi DJ,

Thank you for creating this pull request.
I've added you as a Contributor (role) on JIRA, so you can now be assigned to 
ARIA issues. I've assigned you to ARIA-277 as well.

Regarding the PR itself, it seems to be currently failing some CI tests.
Please see these links:
https://github.com/apache/incubator-ariatosca/pull/179
https://travis-ci.org/apache/incubator-ariatosca/builds/251017348?utm_source=github_status&utm_medium=notification
https://ci.appveyor.com/project/ApacheSoftwareFoundation/incubator-ariatosca/build/1.0.2410


Let me know if you need any help trying to debug or figure out these issues
:)

Ran

On Sun, Jun 11, 2017 at 11:36 AM, Ran Ziv <r...@gigaspaces.com> wrote:

> Thanks DJ.
>
> Note that in order for the project to be able to accept your pull 
> request, you'd first have to sign up Apache's ICLA agreement.
> See more here <https://www.apache.org/dev/new-committers-guide.html>.
>
> Ran
>
> On Fri, Jun 9, 2017 at 2:04 PM, D Jayachandran < 
> d.jayachand...@ericsson.com> wrote:
>
>> Hi Ran/Tal,
>>
>> Thanks for the confirmation. I have created a JIRA issue
>> https://issues.apache.org/jira/browse/ARIA-277
>> We will let you know when we fork and make a pull request for this.
>>
>> Regards,
>> DJ
>> -----Original Message-----
>> From: Tal Liron [mailto:t...@gigaspaces.com]
>> Sent: Thursday, June 08, 2017 11:47 PM
>> To: dev@ariatosca.incubator.apache.org
>> Subject: Re: Missing support for type qualified name
>>
>> Thanks, DJ. This was on the list of things to do but we indeed forgot 
>> to create a JIRA for it...
>>
>> On Thu, Jun 8, 2017 at 8:24 AM, Ran Ziv <r...@gigaspaces.com> wrote:
>>
>> > Hi DJ,
>> >
>> > Sounds good. Feel free to create a new JIRA yourself!  And thanks 
>> > for posting on the dev list before creating this issue.
>> > One small note, I'd personally think of this as a "story" rather 
>> > than a "bug" - We don't yet claim to be 100% TOSCA complaint, and 
>> > we're familiar with several other missing spec sections 
>> > implementations at
>> the moment.
>> >
>> > Let me know if you need any help.
>> > Tal might have more to add on this (Type qualified name) as well.
>> >
>> > Thank you
>> > Ran
>> >
>> >
>> > On Wed, Jun 7, 2017 at 3:35 PM, D Jayachandran < 
>> > d.jayachand...@ericsson.com>
>> > wrote:
>> >
>> > > Hi,
>> > >
>> > > TOSCA Simple Yaml 1.0 profile specification supports usage of  
>> > > the following Namespace Alias
>> > >
>> > >   1.  Shorthand Name
>> > >   2.  Type Qualified Name
>> > >   3.  Type URI
>> > >
>> > > ARIA currently supports only "Shorthand Name" and "Type URI". The 
>> > > support for "Type Qualified Name" is missing which is required to 
>> > > adhere with the TOSCA Simple yaml 1.0 specifications. Could this 
>> > > be considered as bug
>> > and a
>> > > JIRA issue opened for this ?
>> > > We would like to start our contribution with this.
>> > >
>> > >
>> > > Regards,
>> > > DJ
>> > >
>> > >
>> >
>>
>>
>>
>> --
>> Tal Liron
>> Senior Engineer
>> t...@gigaspaces.com | +1 (773) 828-9339 Cloudify | 
>> http://getcloudify.org 
>> <http://getcloudify.org?utm_source=signaturesatori&utm_mediu
>> m=email&utm_campaign=general_signature>
>>
>> <https://twitter.com/CloudifySource>
>> <https://www.linkedin.com/groups/8467478>
>> <https://github.com/cloudify-cosmo>   <https://github.com/cloudify-cosmo>
>> [image: Azure Webinar]
>> <http://getcloudify.org/webinars/Azure-plugin-for-cloudify-
>> webinar.html?utm_source=signaturesatori&utm_medium=
>> email&utm_campaign=general_signature>
>>
>
>

Reply via email to