Hi All,

I have created the below JIRA story as updated below.

https://issues.apache.org/jira/browse/ARIA-438 


Regards,
DJ

-----Original Message-----
From: D Jayachandran [mailto:d.jayachand...@ericsson.com] 
Sent: Monday, February 12, 2018 8:29 PM
To: dev@ariatosca.incubator.apache.org
Subject: RE: ARIA-118 plugin.yaml importing

Hi All,

As discussed, The PR is submitted for the 1st point mentioned in ARIA-118.
I would be creating 2 separate JIRA stories for the points 2 & 3 and 
contributing it.

Regards,
DJ
-----Original Message-----
From: D Jayachandran [mailto:d.jayachand...@ericsson.com]
Sent: Friday, December 08, 2017 2:14 PM
To: dev@ariatosca.incubator.apache.org
Subject: RE: ARIA-118 plugin.yaml importing

Hi Tal,

Do you have any comments for this PR ? And can you also share your comments for 
my proposal to handle global TOSCA type definitions.

Regards,
DJ
-----Original Message-----
From: D Jayachandran [mailto:d.jayachand...@ericsson.com]
Sent: Thursday, December 07, 2017 11:50 AM
To: dev@ariatosca.incubator.apache.org
Subject: RE: ARIA-118 plugin.yaml importing

Hi Tal,

Finally I was able to rebase and create a new PR for this JIRA. This PR address 
the main improvement of using the "plugin.yaml" in a more efficient way in the 
service templates.

But I could find there is a improvement item in the same JIRA issue outside of 
the plugins usage. Please find the text from JIRA as such.
        " The import mechanism could look for imports in the resource-storage 
as well - There could be a directory on the resource-storage designated for 
storing global yaml files for import, thereby simplifying reuse of yaml imports 
across service-templates." 
 
I believe this is addressing the need for a global repository like plugins 
which would just contain the yaml files containing the different TOSCA types. 
We are seeing this repository as "type_definitions" and the yaml files within 
them as "type_definition_files". With a repository as such we can import the 
yaml files in our service-templates as we are handling the plugin import with 
this PR.

My proposal is as below for having a global respository to store YAML files and 
importing them in service templates

Repository structure:
        .aria/type_definitions/<name>_<version>/*.yaml

Import definition:
        imports:
            - file: <name>_<version>
                     repository: type_definitions
 
The <name> and <version> of a type definition file would be got from the 
metadata section in the service template.

Sample type_definition file

tosca_definitions_version: tosca_simple_yaml_1_0

metadata:
  template_name: test
  template_author: evevenu
  template_version: "1.0"

node_types:
    non_normative_type_definition_compute:
        derived_from: tosca.nodes.Compute
        properties:
            name:
              type: string
              required: true
            password:
              type: string
              required: true


If you are fine with this, Can we open a new JIRA and contribute it ?
We are already working on this from our side as we have a strong use case for 
it.

Regards,
DJ
-----Original Message-----
From: Tal Liron [mailto:t...@cloudify.co]
Sent: Monday, December 04, 2017 7:22 PM
To: dev@ariatosca.incubator.apache.org
Subject: Re: ARIA-118 plugin.yaml importing

Sorry, but I don't think we did a thorough review yet. However, feel free to 
rebase on master and push it again to ensure that the CI tests pass.

On Mon, Dec 4, 2017 at 2:48 PM, Thomas Nadeau <tnadeaua...@gmail.com> wrote:

> BTW I noticed that the Travis CI failed for your PR earlier. Tal and I 
> discussed and he thinks this might be fixed with a rebase now that
> ARIA-1 has been pushed.  You can test this theory for yourself by 
> rebasing your branch.
>
> --Tom
>
>
> On Mon, Dec 4, 2017 at 12:31 PM, D Jayachandran < 
> d.jayachand...@ericsson.com
> > wrote:
>
> > Thanks Thomas, I made the PR now.
> >
> > -----Original Message-----
> > From: Thomas Nadeau [mailto:tnad...@apache.org]
> > Sent: Monday, December 04, 2017 1:07 PM
> > To: dev@ariatosca.incubator.apache.org
> > Subject: Re: ARIA-118 plugin.yaml importing
> >
> > Nothing has changed for non-committers; use the canonical GitHub
> fork->push
> > patches->propose patch request method
> > on the same two GitHub repos:
> >
> > https://github.com/apache/incubator-ariatosca-website
> >
> > and
> >
> > https://github.com/apache/incubator-ariatosca
> >
> > I’ll be on slack from now too if you need additional help.
> >
> > —Tom
> >
> >
> > On Dec 4, 2017, at 8:28 AM, D Jayachandran 
> > <d.jayachand...@ericsson.com>
> > wrote:
> >
> > Hi,
> >
> > I need to contribute for this JIRA item. Previously I had made my 
> > contribution by forking from the apache-ariatosca project.
> > Is the process changed now ? What is the process which I should 
> > follow
> now
> > ?
> >
> >
> > Regards,
> > DJ
> >
>

Reply via email to