[
https://issues.apache.org/jira/browse/ARIES-727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13085349#comment-13085349
]
Valentin Mahrwald commented on ARIES-727:
-----------------------------------------
Looks good to me from the expression engine. Amazingly small change :)
The only small nit is whether we would want to implement the put method on the
proxy map passed to the jexl MapContext since that method can actually get
called. Maybe have a local storage for that or throw an explicit
UnsupportedOperationException?
As far as I could see we will also need two more changes (of including the
bundle) to make the itests and the annotation itests work because Blueprint now
also depends on commons-jexl. Looking at the slightly larger picture, I would
think this ought to be an optional dependency rather than a mandatory import
(which it ends up being currently) so that people can use Blueprint without
having to have jexl. What do you think?
Kind regards,
Valentin
> support syntax : ${a+b} in blueprint-cm
> ----------------------------------------
>
> Key: ARIES-727
> URL: https://issues.apache.org/jira/browse/ARIES-727
> Project: Aries
> Issue Type: New Feature
> Components: Blueprint
> Affects Versions: blueprint-0.3.1, blueprint-0.4.0
> Reporter: Rex Wang
> Assignee: Rex Wang
> Fix For: blueprint-0.4.0
>
> Attachments: ARIES-727-blueprint-cm.patch
>
>
> I am wondering if Aries blueprint-cm support such scenario:
> <cm:property-placeholder id="property-placeholder" persistent-id="o.a.b.com"
> placeholder-prefix="${" placeholder-suffix="}">
> <cm:default-properties>
> <cm:property name="port" value="12345"/>
> <cm:property name="offset" value="10"/>
> </cm:default-properties>
> </cm:property-placeholder>
> <xxx:conn name="loc" uri="http://localhost:${port+offset}"/>
> I have a test, but seems the ${port+offset} can not be replaced with value
> "12355".
> -Rex
> -----------------------
> Hi Rex,
> to my knowledge (substantiated with a quick code inspection) the placeholders
> in Aries today support no operators or arithmetic like that. But please do
> raise an Improvement JIRA for the future :)
> Regards,
> Valentin
> -----------------------
> When we support this, we need to perform a 'plus' or string concatenate
> operation based on the variable type:).
> Therefore. when specifying the property in the blueprint xml, the explicit
> type should be specified if not string.
> Regards,
> Emily
> -----------------------
> I _think_ I wrote something like this for xbean-blueprint since it didn't
> look like blueprint supported it. IIRC I used the same calculation engine as
> the geronimo config substitutions. I think you can infer what kind of
> calculation to do (addition or concatenation) from the type of the property
> you end up setting.
> thanks
> david jencks
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
