On Sep 19, 2011, at 3:35 PM, Alasdair Nottingham wrote:

> +1
> 
> source builds ok, legal files look file. rat:check failed because it
> couldn't fine a license in the DEPENDENCIES file, but I don't think that is
> important.

Agreed. A few comments/additional information...

1) DEPENDENCIES is generated as part of a build, is not in svn, and there's no 
real reason for it to be in the source release. Would really be best to leave 
it out... Either generate DEPENDENCIES in target or exclude from by some other 
means.
2) Since DEPENDENCIES is machine generated, it does not require a source 
license header.

--kevan

Reply via email to