On Nov 15, 2011, at 10:59 AM, Daniel Kulp wrote: > On Tuesday, November 15, 2011 10:50:31 AM David Jencks wrote: >> -1 to the <relative-path>s >> >> We should not be embedding assumptions about how much of the project you >> checked out in the poms. You're basically expected to check out one module >> and build it. What problem are you trying to solve? I had no problem >> building the all-in-one after I built the parents and the eba-maven-plugin. >> >> These paths are going to be completely wrong in a release tag. >> >> This is not a technical veto since apparently both ways work, but I feel >> pretty strongly about this. > > I feel pretty strong that they SHOULD be there. IMO, we need to be able > to > just checkout trunk and run "mvn install" and have it build and test and > such. That's how maven projects work. Having it work properly "out of > the > box" for new users, IMO, trumps aesthetics of a release tag where the > relativePath would be ignore anyway. Without them, you get all kinds of > warnings (if they work at all).
Since you are proposing the change, can you explain exactly what the problem you are trying to solve is and how to reproduce it? I haven't encountered _any_ problems that this change would solve so it seems like a bad idea with no redeeming features. Also, what are the warnings you are referring to? thanks david jencks > > Dan > > > >> >> thanks >> david jencks >> >> On Nov 15, 2011, at 10:16 AM, [email protected] wrote: >>> Author: dkulp >>> Date: Tue Nov 15 18:16:00 2011 >>> New Revision: 1202350 >>> >>> URL: http://svn.apache.org/viewvc?rev=1202350&view=rev >>> Log: >>> More maven 3 fixes and snapshot deploy fix >>> >>> Modified: >>> aries/trunk/application/application-modeller/pom.xml >>> aries/trunk/quiesce/pom.xml >>> >>> Modified: aries/trunk/application/application-modeller/pom.xml >>> URL: >>> http://svn.apache.org/viewvc/aries/trunk/application/application-modell >>> er/pom.xml?rev=1202350&r1=1202349&r2=1202350&view=diff >>> ======================================================================= >>> ======= --- aries/trunk/application/application-modeller/pom.xml >>> (original) +++ aries/trunk/application/application-modeller/pom.xml Tue >>> Nov 15 18:16:00 2011 @@ -22,7 +22,7 @@ >>> >>> <groupId>org.apache.aries</groupId> >>> <artifactId>java5-parent</artifactId> >>> <version>0.5-SNAPSHOT</version> >>> >>> - <relativePath /> >>> + >>> <relativePath>../../parent/default-parent/java5-parent</relativePath>> >>> </parent> >>> >>> <groupId>org.apache.aries.application</groupId> >>> >>> Modified: aries/trunk/quiesce/pom.xml >>> URL: >>> http://svn.apache.org/viewvc/aries/trunk/quiesce/pom.xml?rev=1202350&r1 >>> =1202349&r2=1202350&view=diff >>> ======================================================================= >>> ======= --- aries/trunk/quiesce/pom.xml (original) >>> +++ aries/trunk/quiesce/pom.xml Tue Nov 15 18:16:00 2011 >>> @@ -19,7 +19,7 @@ >>> >>> <parent> >>> >>> <groupId>org.apache.aries</groupId> >>> <artifactId>java5-parent</artifactId> >>> >>> - <version>0.4</version> >>> + <version>0.5-SNAPSHOT</version> >>> >>> <relativePath>../parent/default-parent/java5-parent</rel >>> ativePath>> >>> </parent> >>> >>> @@ -28,6 +28,7 @@ >>> >>> <artifactId>quiesce</artifactId> >>> <name>Apache Aries Quiesce</name> >>> <packaging>pom</packaging> >>> >>> + <version>0.3.1-SNAPSHOT</version> >>> >>> <description> >>> >>> Quiesce support for Aries - reactor pom > -- > Daniel Kulp > [email protected] > http://dankulp.com/blog > Talend - http://www.talend.com
