Hi,

Am 25.11.2011 um 12:52 schrieb Alasdair Nottingham:

> Rather than rely on system properties wouldn't it be better to use
> ConfigAdmin for this kind of configuration? That way we aren't trying to
> use JVM singleton configuration for a dynamic modular environment?

Looking at the code it seems to use framework properties, which is not as bad 
IMHO (I agrre, though, System properties are a definite no-go in OSGi bundles 
;-)

Also, in this case, I would assume that Configuration Admin properties are not 
ready in a timely manner and may give the impression of dynamicity, which 
cannot be guaranteed for a WeavingHook: If a class is woven and later 
configured to not be woven it will only become "unwoven" if the using bundle is 
restarted (or even rewired).

Regards
Felix

> 
> On 21 November 2011 15:46, Guillaume Nodet (Resolved) (JIRA) <
> [email protected]> wrote:
> 
>> 
>>    [
>> https://issues.apache.org/jira/browse/ARIES-786?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel]
>> 
>> Guillaume Nodet resolved ARIES-786.
>> -----------------------------------
>> 
>>   Resolution: Fixed
>> 
>>> Ability to control the list of woven classes using system properties
>>> --------------------------------------------------------------------
>>> 
>>>                Key: ARIES-786
>>>                URL: https://issues.apache.org/jira/browse/ARIES-786
>>>            Project: Aries
>>>         Issue Type: Improvement
>>>         Components: Parent
>>>   Affects Versions: proxy.impl-0.4
>>>           Reporter: Guillaume Nodet
>>>           Assignee: Guillaume Nodet
>>>            Fix For: proxy.impl-0.4.1
>>> 
>>> 
>>> Introduce org.apache.aries.proxy.weaving.enabled and
>> org.apache.aries.proxy.weaving.disabled containing a comma separated list
>> of wildcard matching filters to allow / disallow the filtering in and out
>> of classes for the weaving process.
>> 
>> --
>> This message is automatically generated by JIRA.
>> If you think it was sent incorrectly, please contact your JIRA
>> administrators:
>> https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
>> For more information on JIRA, see: http://www.atlassian.com/software/jira
>> 
>> 
>> 
> 
> 
> -- 
> Alasdair Nottingham
> [email protected]

Reply via email to