Hi Emily, Why don't you simply go ahead with your changes. spi-fly isn't part of the main build yet so I should be able to work on that separately, simply by looking at your changes...
Cheers, David On 27 January 2012 10:16, Emily Jiang <[email protected]> wrote: > Hi David, > > Looks like we need a bit more coordination:). I got proxy-impl (worked > around the issue of overriding final methods) and web unit test working > with asm4. At the moment, just trying to get its itest working. When you > see this, can you contact me so that we can put the fixes together? > > Regards, > Emily > > On Fri, Jan 27, 2012 at 9:20 AM, David Jencks (Updated) (JIRA) < > [email protected]> wrote: > >> >> [ >> https://issues.apache.org/jira/browse/ARIES-817?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel] >> >> David Jencks updated ARIES-817: >> ------------------------------- >> >> Attachment: ARIES-817-spi-fly.diff >> >> Most of spi-fly is easy to fix... would it be possible to pull in the >> proxy modules' osgi friendly class writer rather than copying the code? >> >> I'd suggest waiting to commit this until I'm more sure the new code works >> with the rest of aries, but I could commit it now if you'd like. >> >> > Upgrade to asm 4 for java 7 support >> > ----------------------------------- >> > >> > Key: ARIES-817 >> > URL: https://issues.apache.org/jira/browse/ARIES-817 >> > Project: Aries >> > Issue Type: Improvement >> > Components: Application, Blueprint, Proxy >> > Reporter: David Jencks >> > Assignee: David Jencks >> > Attachments: ARIES-817-spi-fly.diff >> > >> > >> > asm 3 generates java 7 incompatible classes. We need to upgrade to asm >> 4 to be able to support running on java 7. There are a few simple code >> changes needed in the proxy module, and a couple nasty workarounds for >> newly final methods and private fields. There is also a lot of work in >> integration tests and pom versions to make everything else work. >> > I plan to add patches here as I proceed and when everything works I'll >> think about committing. >> >> -- >> This message is automatically generated by JIRA. >> If you think it was sent incorrectly, please contact your JIRA >> administrators: >> https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa >> For more information on JIRA, see: http://www.atlassian.com/software/jira >> >> >> > > > -- > Thanks > Emily > ================= > Emily Jiang > [email protected]
