Sounds like a nice-to-have. I'm happy either way. +1
On 26 July 2012 15:19, Holly Cummins <[email protected]> wrote: > I've just checked and # can be used for comments in the > META-INF/services file, so I *could* add in a license. I'm not sure > it's worth bothering, but it also might not hurt anything, and it > would keep RAT happy. What do people think? > > On Thu, Jul 26, 2012 at 3:12 PM, Holly Cummins > <[email protected]> wrote: > > Hi, > > > > Thanks for checking. I see the same failure, but the file is so trivial > that > > I decided that it didn't need a license file. (It's just the name of a > class > > which implements the interface of the file name.) In fact, I'm not sure > if > > META-INF/services even defines a comment format. > > > > If anyone thinks otherwise, I can dump that bundle from the release ... > > > > Cheers, > > Holly > > > > > > > > On 26 Jul 2012, at 09:58, Christoph Gritschenberger > > <[email protected]> wrote: > > > >> I got this when running the verify-script. > >> > >> > >> RAT FAILURE:????? > >> > >> > src/main/resources/META-INF/services/org.apache.aries.application.modelling.ServiceModeller > >> > >> > >> It's in org.apache.aries.ejb.modeller-1.0.0. > >> The file appears to have no license-header. > >> > >> kind regards, > >> christoph > >> > >> On 26/07/12 00:25, Holly Cummins wrote: > >>> > >>> I've staged a release candidate for the next set of application > >>> bundle, transaction bundles, ejb bundles, jndi-url bundle, jmx > >>> uber-bundles, and proxy uber-bundle. This is a big one. I've managed > >>> to release almost all of blueprint except for the uber-bundle and its > >>> compatibility bundle. I've got to the uber-bundles for proxy and jmx. > >>> > >>> There's been a lot of activity in blueprint-cm lately, so Guillaume, > >>> do speak up if you think it's not quite ready to get pushed out, and > >>> I'll remove it from this release. > >>> > >>> > >>> WHAT'S BEEN RELEASED? > >>> > >>> The modules are staged and tagged as follows: > >>> > >>> application-modeller > >>> > >>> > https://svn.apache.org/repos/asf/aries/tags/org.apache.aries.application.modeller-1.0.0 > >>> > >>> application-runtime-framework-management > >>> > >>> > https://svn.apache.org/repos/asf/aries/tags/org.apache.aries.application.runtime.framework.management-1.0.0 > >>> > >>> transaction-blueprint > >>> > >>> > https://svn.apache.org/repos/asf/aries/tags/org.apache.aries.transaction.blueprint-1.0.0 > >>> > >>> transaction-wrappers/ > >>> > >>> > https://svn.apache.org/repos/asf/aries/tags/org.apache.aries.transaction.wrappers-1.0.0 > >>> > >>> blueprint-annotation-impl > >>> > >>> > https://svn.apache.org/repos/asf/aries/tags/org.apache.aries.blueprint.annotation.impl-1.0.0 > >>> > >>> blueprint-cm > >>> > >>> > https://svn.apache.org/repos/asf/aries/tags/org.apache.aries.blueprint.cm-1.0.0 > >>> > >>> blueprint-core-compatibility > >>> > >>> > https://svn.apache.org/repos/asf/aries/tags/org.apache.aries.blueprint.core.compatibility-1.0.0 > >>> > >>> blueprint-jexl-evaluator > >>> > >>> > https://svn.apache.org/repos/asf/aries/tags/org.apache.aries.blueprint.jexl.evaluator-1.0.0 > >>> > >>> blueprint-sample-annotation/ > >>> > >>> > https://svn.apache.org/repos/asf/aries/tags/org.apache.aries.blueprint.sample-annotation-1.0.0 > >>> > >>> blueprint-sample-fragment > >>> > >>> > https://svn.apache.org/repos/asf/aries/tags/org.apache.aries.blueprint.sample-fragment-1.0.0 > >>> > >>> blueprint-sample > >>> > >>> > https://svn.apache.org/repos/asf/aries/tags/org.apache.aries.blueprint.sample-1.0.0 > >>> > >>> blueprint-testbundlea > >>> > >>> > https://svn.apache.org/repos/asf/aries/tags/org.apache.aries.blueprint.testbundlea-1.0.0 > >>> > >>> blueprint-testquiescebundle > >>> > >>> > https://svn.apache.org/repos/asf/aries/tags/org.apache.aries.blueprint.testquiescebundle-1.0.0 > >>> > >>> ejb-modeller > >>> > >>> > https://svn.apache.org/repos/asf/aries/tags/org.apache.aries.ejb.modeller-1.0.0 > >>> > >>> openejb-extender > >>> > >>> > https://svn.apache.org/repos/asf/aries/tags/org.apache.aries.ejb.openejb.extender-1.0.0 > >>> > >>> jmx-blueprint-bundle > >>> > >>> > https://svn.apache.org/repos/asf/aries/tags/org.apache.aries.jmx.blueprint-1.0.0 > >>> > >>> jmx-bundle > >>> https://svn.apache.org/repos/asf/aries/trunk/jmx/jmx-bundle > >>> https://svn.apache.org/repos/asf/aries/tags/org.apache.aries.jmx-1.0.0 > >>> > >>> jndi-url > >>> > >>> > https://svn.apache.org/repos/asf/aries/tags/org.apache.aries.jndi.url-1.0.0 > >>> > >>> jpa-blueprint-aries > >>> > >>> > https://svn.apache.org/repos/asf/aries/tags/org.apache.aries.jpa.blueprint.aries-1.0.0 > >>> > >>> proxy-bundle > >>> > https://svn.apache.org/repos/asf/aries/tags/org.apache.aries.proxy-1.0.0 > >>> > >>> > >>> > >>> VERIFYING THE RELEASE > >>> > >>> Instructions for verifying the release are at > >>> http://aries.apache.org/development/verifyingrelease.html. > >>> Alternately, cut and paste the following to run a full check: > >>> > >>> wget --no-check-certificate > >>> > https://svn.apache.org/repos/asf/aries/scripts/verify_staged_release.sh > >>> chmod a+x verify_staged_release.sh > >>> ./verify_staged_release.sh 087 mytempdirectory 2>&1 | tee > >>> verifyresults.txt > >>> grep FAIL verifyresults.txt > >>> grep ERROR verifyresults.txt > >>> > >>> > >>> SOURCE ZIPS > >>> > >>> Artifacts are in one staged repo, > >>> https://repository.apache.org/content/repositories/orgapachearies-087/ > . > >>> Links to the *.zip files for each module are provided below: > >>> > >>> > >>> > https://repository.apache.org/content/repositories/orgapachearies-087/org/apache/aries/application/org.apache.aries.application.modeller/1.0.0/org.apache.aries.application.modeller-1.0.0-source-release.zip > >>> > >>> > >>> > https://repository.apache.org/content/repositories/orgapachearies-087/org/apache/aries/application/org.apache.aries.application.runtime.framework.management/1.0.0/org.apache.aries.application.runtime.framework.management-1.0.0-source-release.zip > >>> > >>> > >>> > https://repository.apache.org/content/repositories/orgapachearies-087/org/apache/aries/blueprint/org.apache.aries.blueprint.annotation.impl/1.0.0/org.apache.aries.blueprint.annotation.impl-1.0.0-source-release.zip > >>> > >>> > >>> > https://repository.apache.org/content/repositories/orgapachearies-087/org/apache/aries/blueprint/org.apache.aries.blueprint.cm/1.0.0/org.apache.aries.blueprint.cm-1.0.0-source-release.zip > >>> > >>> > >>> > https://repository.apache.org/content/repositories/orgapachearies-087/org/apache/aries/blueprint/org.apache.aries.blueprint.core.compatibility/1.0.0/org.apache.aries.blueprint.core.compatibility-1.0.0-source-release.zip > >>> > >>> > >>> > https://repository.apache.org/content/repositories/orgapachearies-087/org/apache/aries/blueprint/org.apache.aries.blueprint.jexl.evaluator/1.0.0/org.apache.aries.blueprint.jexl.evaluator-1.0.0-source-release.zip > >>> > >>> > >>> > https://repository.apache.org/content/repositories/orgapachearies-087/org/apache/aries/blueprint/org.apache.aries.blueprint.sample/1.0.0/org.apache.aries.blueprint.sample-1.0.0-source-release.zip > >>> > >>> > >>> > https://repository.apache.org/content/repositories/orgapachearies-087/org/apache/aries/blueprint/org.apache.aries.blueprint.sample-annotation/1.0.0/org.apache.aries.blueprint.sample-annotation-1.0.0-source-release.zip > >>> > >>> > >>> > https://repository.apache.org/content/repositories/orgapachearies-087/org/apache/aries/blueprint/org.apache.aries.blueprint.sample-fragment/1.0.0/org.apache.aries.blueprint.sample-fragment-1.0.0-source-release.zip > >>> > >>> > >>> > https://repository.apache.org/content/repositories/orgapachearies-087/org/apache/aries/blueprint/org.apache.aries.blueprint.testbundlea/1.0.0/org.apache.aries.blueprint.testbundlea-1.0.0-source-release.zip > >>> > >>> > >>> > https://repository.apache.org/content/repositories/orgapachearies-087/org/apache/aries/blueprint/org.apache.aries.blueprint.testquiescebundle/1.0.0/org.apache.aries.blueprint.testquiescebundle-1.0.0-source-release.zip > >>> > >>> > >>> > https://repository.apache.org/content/repositories/orgapachearies-087/org/apache/aries/ejb/org.apache.aries.ejb.modeller/1.0.0/org.apache.aries.ejb.modeller-1.0.0-source-release.zip > >>> > >>> > >>> > https://repository.apache.org/content/repositories/orgapachearies-087/org/apache/aries/ejb/org.apache.aries.ejb.openejb.extender/1.0.0/org.apache.aries.ejb.openejb.extender-1.0.0-source-release.zip > >>> > >>> > >>> > https://repository.apache.org/content/repositories/orgapachearies-087/org/apache/aries/jmx/org.apache.aries.jmx/1.0.0/org.apache.aries.jmx-1.0.0-source-release.zip > >>> > >>> > >>> > https://repository.apache.org/content/repositories/orgapachearies-087/org/apache/aries/jmx/org.apache.aries.jmx.blueprint/1.0.0/org.apache.aries.jmx.blueprint-1.0.0-source-release.zip > >>> > >>> > >>> > https://repository.apache.org/content/repositories/orgapachearies-087/org/apache/aries/jndi/org.apache.aries.jndi.url/1.0.0/org.apache.aries.jndi.url-1.0.0-source-release.zip > >>> > >>> > >>> > https://repository.apache.org/content/repositories/orgapachearies-087/org/apache/aries/jpa/org.apache.aries.jpa.blueprint.aries/1.0.0/org.apache.aries.jpa.blueprint.aries-1.0.0-source-release.zip > >>> > >>> > >>> > https://repository.apache.org/content/repositories/orgapachearies-087/org/apache/aries/proxy/org.apache.aries.proxy/1.0.0/org.apache.aries.proxy-1.0.0-source-release.zip > >>> > >>> > >>> > https://repository.apache.org/content/repositories/orgapachearies-087/org/apache/aries/transaction/org.apache.aries.transaction.blueprint/1.0.0/org.apache.aries.transaction.blueprint-1.0.0-source-release.zip > >>> > >>> > >>> > https://repository.apache.org/content/repositories/orgapachearies-087/org/apache/aries/transaction/org.apache.aries.transaction.wrappers/1.0.0/org.apache.aries.transaction.wrappers-1.0.0-source-release.zip > >>> > >>> If you've been bored reading that list, imagine how I've felt preparing > >>> it. :) > >>> > >>> The RAT and IANAL build checks passed. Note that, although RAT is > >>> configured to ignore *.MF and other files that do not require the ASF > >>> licence, theses files are still reported incorrectly as RAT failures. > As > >>> before, archetype-catalog.xml files fail the SHA checks but probably > >>> shouldn't be checked. There are also some spurious RAT warnings for > >>> NOTICE.vm files. There was also a META-INF/services file in the > >>> ejb-modeller component which doesn't have copyrights, correctly, > >>> I believe, since it's a trivial file. > >>> > >>> COMPLIANCE TESTS > >>> > >>> The CT reports can be viewed at > >>> http://aries.apache.org/downloads/ct/1.0.0/, and the previous set of > >>> reports are at http://aries.apache.org/downloads/ct/0.3/ > >>> > >>> org.osgi.test.cases.blueprint.html:7 (5) > >>> /org.osgi.test.cases.blueprint.java5.html:0 (0) > >>> org.osgi.test.cases.blueprint.secure.html:0 (0) > >>> org.osgi.test.cases.jmx.html:18 (18) > >>> org.osgi.test.cases.jndi.html:7 (3, or 5 when run on recent Sun VMs) > >>> org.osgi.test.cases.jndi.secure.html:0 (0) > >>> org.osgi.test.cases.transaction.html:0 (0) > >>> > >>> > >>> The vote will be open for 72 hours, closing Monday night. > >>> > >>> [ ] +1 > >>> [ ] 0 > >>> [ ] -1 > >>> > >> > >> > > >
