If anyone is curious, I've had a dig into the missing slf4j versions in the uber bundle, and it looks like bnd/the bundle plugin don't pick up package versions for transitive dependencies. Thinking about it, this isn't surprising - I don't think bnd possibly could work out the package of a class if the containing bundle isn't on its classpath. The fix is to include all the dependencies of child bundles in the uber-bundle pom. This feels a bit clunky, but less clunky than explicitly adding the package imports.
Holly On Sat, Jul 28, 2012 at 6:58 AM, Holly Cummins <[email protected]> wrote: > Darn. :( > > Thank you for checking the manifests so thoroughly. Comments inline. > > On Fri, Jul 27, 2012 at 6:41 PM, Timothy Ward <[email protected]> wrote: > >> Transaction blueprint has no import version for org.osgi.service.cm - Also I >> don't think it needs this import at all. > > I wonder why someone bothered to add it manually, if it wasn't needed? > I've had a look and I can't see any references to it in the code, and > as far as I can see it's not a special 'import this to indicate > something' package. > >> Blueprint sample, sample annotation, sample fragment and the two test >> bundles have no export versions for their blueprint sample packages (this >> may not be a deal-breaker) > > I think these are really test bundles, rather than sample bundles, > despite the name, so I think the versioning is a nice to have at most. > It's a tricky call because if they're sample bundles we should display > best practices, but for test bundles I think ease of maintenance is > the most important thing, so for test bundles I'm not sure it would > even be worth adding versions in for trunk. I think I will opt to > release the current version-less bundles, though, whatever we do in > trunk. > > >> Ejb modeller exports its modelling package at 0.1.0 and imports at 0.1 to 1 > > Doh, I wonder how that one escaped all my 1.0.0 grepping? Clearly a > must-fix, and thank goodness you caught it, since otherwise a fix > would have broken consumers. > >> Jmx blueprint exports org.apache.aries.jmx.blueprint.codec with no version. >> It also imports slf4j with no version and most of its other package imports >> have no upper bound. > > This is another one where it means jmx.blueprint.core escaped with > missing versions on its export. Looks like there's no package info in > that codec package. However, I've just checked and its imports are > fine. I suspect this may be a build issue where bnd is somehow not > able to work out import versions in the uber-bundles, which may not be > totally trivial to fix. I'll see if I can work out where it's going > wrong. > >> Proxy bundle has no versions on its imports for org.slf4j or >> org.osgi.util.tracker (proxy impl is fine) > > As above, it's good news that proxy impl is fine, and clearly there's > a build issue which needs fixing. > >> In my view transaction, ejb, Jmx and proxy need fixes to their packaging >> before they can go out, but everything else looks good and >> I'm happy to +1 it. I won't stand in the way of the sample bundles being >> released as is, although it is a pretty bad example to set. > > I'll delete transaction blueprint, ejb-modeller, jmx-blueprint, and > proxy from the release repo and remove the tags, and I'll respin just > those bundles as a separate release. I suggest we think of the sample > bundles as test code and release. > >> Sorry to derail your gargantuan task (again). We all really appreciate the >> massive effort you are making with all of it. > > Luckily it's just four bundles to respin. :) > >> >> Tim >> >>> From: [email protected] >>> To: [email protected] >>> Subject: Re: [VOTE] Apache Aries partial application, blueprint, >>> transaction, ejb, jmx, jpa and jndi odds and sods, and one or two >>> uber-bundles release >>> Date: Fri, 27 Jul 2012 13:45:51 +0100 >>> >>> Awesome, thanks Guillaime. I won't close the vote yet, but assuming >>> there are no -1s before tomorrow evening, we are good to go. The next >>> round should finish everything except the itests, samples, and maybe a >>> bit of application stuff. >>> >>> On 27 Jul 2012, at 12:32, Guillaume Nodet <[email protected]> wrote: >>> >>> > +1 >>> > >>> > On Thu, Jul 26, 2012 at 12:25 AM, Holly Cummins < >>> > [email protected]> wrote: >>> > >>> >> I've staged a release candidate for the next set of application >>> >> bundle, transaction bundles, ejb bundles, jndi-url bundle, jmx >>> >> uber-bundles, and proxy uber-bundle. This is a big one. I've managed >>> >> to release almost all of blueprint except for the uber-bundle and its >>> >> compatibility bundle. I've got to the uber-bundles for proxy and jmx. >>> >> >>> >> There's been a lot of activity in blueprint-cm lately, so Guillaume, >>> >> do speak up if you think it's not quite ready to get pushed out, and >>> >> I'll remove it from this release. >>> >> >>> >> >>> >> WHAT'S BEEN RELEASED? >>> >> >>> >> The modules are staged and tagged as follows: >>> >> >>> >> application-modeller >>> >> >>> >> https://svn.apache.org/repos/asf/aries/tags/org.apache.aries.application.modeller-1.0.0 >>> >> >>> >> application-runtime-framework-management >>> >> >>> >> https://svn.apache.org/repos/asf/aries/tags/org.apache.aries.application.runtime.framework.management-1.0.0 >>> >> >>> >> transaction-blueprint >>> >> >>> >> https://svn.apache.org/repos/asf/aries/tags/org.apache.aries.transaction.blueprint-1.0.0 >>> >> >>> >> transaction-wrappers/ >>> >> >>> >> https://svn.apache.org/repos/asf/aries/tags/org.apache.aries.transaction.wrappers-1.0.0 >>> >> >>> >> blueprint-annotation-impl >>> >> >>> >> https://svn.apache.org/repos/asf/aries/tags/org.apache.aries.blueprint.annotation.impl-1.0.0 >>> >> >>> >> blueprint-cm >>> >> >>> >> https://svn.apache.org/repos/asf/aries/tags/org.apache.aries.blueprint.cm-1.0.0 >>> >> >>> >> blueprint-core-compatibility >>> >> >>> >> https://svn.apache.org/repos/asf/aries/tags/org.apache.aries.blueprint.core.compatibility-1.0.0 >>> >> >>> >> blueprint-jexl-evaluator >>> >> >>> >> https://svn.apache.org/repos/asf/aries/tags/org.apache.aries.blueprint.jexl.evaluator-1.0.0 >>> >> >>> >> blueprint-sample-annotation/ >>> >> >>> >> https://svn.apache.org/repos/asf/aries/tags/org.apache.aries.blueprint.sample-annotation-1.0.0 >>> >> >>> >> blueprint-sample-fragment >>> >> >>> >> https://svn.apache.org/repos/asf/aries/tags/org.apache.aries.blueprint.sample-fragment-1.0.0 >>> >> >>> >> blueprint-sample >>> >> >>> >> https://svn.apache.org/repos/asf/aries/tags/org.apache.aries.blueprint.sample-1.0.0 >>> >> >>> >> blueprint-testbundlea >>> >> >>> >> https://svn.apache.org/repos/asf/aries/tags/org.apache.aries.blueprint.testbundlea-1.0.0 >>> >> >>> >> blueprint-testquiescebundle >>> >> >>> >> https://svn.apache.org/repos/asf/aries/tags/org.apache.aries.blueprint.testquiescebundle-1.0.0 >>> >> >>> >> ejb-modeller >>> >> >>> >> https://svn.apache.org/repos/asf/aries/tags/org.apache.aries.ejb.modeller-1.0.0 >>> >> >>> >> openejb-extender >>> >> >>> >> https://svn.apache.org/repos/asf/aries/tags/org.apache.aries.ejb.openejb.extender-1.0.0 >>> >> >>> >> jmx-blueprint-bundle >>> >> >>> >> https://svn.apache.org/repos/asf/aries/tags/org.apache.aries.jmx.blueprint-1.0.0 >>> >> >>> >> jmx-bundle >>> >> https://svn.apache.org/repos/asf/aries/trunk/jmx/jmx-bundle >>> >> https://svn.apache.org/repos/asf/aries/tags/ >>> >> org.apache.aries.jmx-1.0.0 >>> >> >>> >> jndi-url >>> >> https://svn.apache.org/repos/asf/aries/tags/org.apache.aries.jndi.url-1.0.0 >>> >> >>> >> jpa-blueprint-aries >>> >> >>> >> https://svn.apache.org/repos/asf/aries/tags/org.apache.aries.jpa.blueprint.aries-1.0.0 >>> >> >>> >> proxy-bundle >>> >> https://svn.apache.org/repos/asf/aries/tags/org.apache.aries.proxy-1.0.0 >>> >> >>> >> >>> >> >>> >> VERIFYING THE RELEASE >>> >> >>> >> Instructions for verifying the release are at >>> >> http://aries.apache.org/development/verifyingrelease.html. >>> >> Alternately, cut and paste the following to run a full check: >>> >> >>> >> wget --no-check-certificate >>> >> https://svn.apache.org/repos/asf/aries/scripts/verify_staged_release.sh >>> >> chmod a+x verify_staged_release.sh >>> >> ./verify_staged_release.sh 087 mytempdirectory 2>&1 | tee >>> >> verifyresults.txt >>> >> grep FAIL verifyresults.txt >>> >> grep ERROR verifyresults.txt >>> >> >>> >> >>> >> SOURCE ZIPS >>> >> >>> >> Artifacts are in one staged repo, >>> >> https://repository.apache.org/content/repositories/orgapachearies-087/ >>> >> . >>> >> Links to the *.zip files for each module are provided below: >>> >> >>> >> >>> >> https://repository.apache.org/content/repositories/orgapachearies-087/org/apache/aries/application/org.apache.aries.application.modeller/1.0.0/org.apache.aries.application.modeller-1.0.0-source-release.zip >>> >> >>> >> >>> >> https://repository.apache.org/content/repositories/orgapachearies-087/org/apache/aries/application/org.apache.aries.application.runtime.framework.management/1.0.0/org.apache.aries.application.runtime.framework.management-1.0.0-source-release.zip >>> >> >>> >> >>> >> https://repository.apache.org/content/repositories/orgapachearies-087/org/apache/aries/blueprint/org.apache.aries.blueprint.annotation.impl/1.0.0/org.apache.aries.blueprint.annotation.impl-1.0.0-source-release.zip >>> >> >>> >> >>> >> https://repository.apache.org/content/repositories/orgapachearies-087/org/apache/aries/blueprint/org.apache.aries.blueprint.cm/1.0.0/org.apache.aries.blueprint.cm-1.0.0-source-release.zip >>> >> >>> >> >>> >> https://repository.apache.org/content/repositories/orgapachearies-087/org/apache/aries/blueprint/org.apache.aries.blueprint.core.compatibility/1.0.0/org.apache.aries.blueprint.core.compatibility-1.0.0-source-release.zip >>> >> >>> >> >>> >> https://repository.apache.org/content/repositories/orgapachearies-087/org/apache/aries/blueprint/org.apache.aries.blueprint.jexl.evaluator/1.0.0/org.apache.aries.blueprint.jexl.evaluator-1.0.0-source-release.zip >>> >> >>> >> >>> >> https://repository.apache.org/content/repositories/orgapachearies-087/org/apache/aries/blueprint/org.apache.aries.blueprint.sample/1.0.0/org.apache.aries.blueprint.sample-1.0.0-source-release.zip >>> >> >>> >> >>> >> https://repository.apache.org/content/repositories/orgapachearies-087/org/apache/aries/blueprint/org.apache.aries.blueprint.sample-annotation/1.0.0/org.apache.aries.blueprint.sample-annotation-1.0.0-source-release.zip >>> >> >>> >> >>> >> https://repository.apache.org/content/repositories/orgapachearies-087/org/apache/aries/blueprint/org.apache.aries.blueprint.sample-fragment/1.0.0/org.apache.aries.blueprint.sample-fragment-1.0.0-source-release.zip >>> >> >>> >> >>> >> https://repository.apache.org/content/repositories/orgapachearies-087/org/apache/aries/blueprint/org.apache.aries.blueprint.testbundlea/1.0.0/org.apache.aries.blueprint.testbundlea-1.0.0-source-release.zip >>> >> >>> >> >>> >> https://repository.apache.org/content/repositories/orgapachearies-087/org/apache/aries/blueprint/org.apache.aries.blueprint.testquiescebundle/1.0.0/org.apache.aries.blueprint.testquiescebundle-1.0.0-source-release.zip >>> >> >>> >> >>> >> https://repository.apache.org/content/repositories/orgapachearies-087/org/apache/aries/ejb/org.apache.aries.ejb.modeller/1.0.0/org.apache.aries.ejb.modeller-1.0.0-source-release.zip >>> >> >>> >> >>> >> https://repository.apache.org/content/repositories/orgapachearies-087/org/apache/aries/ejb/org.apache.aries.ejb.openejb.extender/1.0.0/org.apache.aries.ejb.openejb.extender-1.0.0-source-release.zip >>> >> >>> >> >>> >> https://repository.apache.org/content/repositories/orgapachearies-087/org/apache/aries/jmx/org.apache.aries.jmx/1.0.0/org.apache.aries.jmx-1.0.0-source-release.zip >>> >> >>> >> >>> >> https://repository.apache.org/content/repositories/orgapachearies-087/org/apache/aries/jmx/org.apache.aries.jmx.blueprint/1.0.0/org.apache.aries.jmx.blueprint-1.0.0-source-release.zip >>> >> >>> >> >>> >> https://repository.apache.org/content/repositories/orgapachearies-087/org/apache/aries/jndi/org.apache.aries.jndi.url/1.0.0/org.apache.aries.jndi.url-1.0.0-source-release.zip >>> >> >>> >> >>> >> https://repository.apache.org/content/repositories/orgapachearies-087/org/apache/aries/jpa/org.apache.aries.jpa.blueprint.aries/1.0.0/org.apache.aries.jpa.blueprint.aries-1.0.0-source-release.zip >>> >> >>> >> >>> >> https://repository.apache.org/content/repositories/orgapachearies-087/org/apache/aries/proxy/org.apache.aries.proxy/1.0.0/org.apache.aries.proxy-1.0.0-source-release.zip >>> >> >>> >> >>> >> https://repository.apache.org/content/repositories/orgapachearies-087/org/apache/aries/transaction/org.apache.aries.transaction.blueprint/1.0.0/org.apache.aries.transaction.blueprint-1.0.0-source-release.zip >>> >> >>> >> >>> >> https://repository.apache.org/content/repositories/orgapachearies-087/org/apache/aries/transaction/org.apache.aries.transaction.wrappers/1.0.0/org.apache.aries.transaction.wrappers-1.0.0-source-release.zip >>> >> >>> >> If you've been bored reading that list, imagine how I've felt >>> >> preparing >>> >> it. :) >>> >> >>> >> The RAT and IANAL build checks passed. Note that, although RAT is >>> >> configured to ignore *.MF and other files that do not require the ASF >>> >> licence, theses files are still reported incorrectly as RAT >>> >> failures. As >>> >> before, archetype-catalog.xml files fail the SHA checks but probably >>> >> shouldn't be checked. There are also some spurious RAT warnings for >>> >> NOTICE.vm files. There was also a META-INF/services file in the >>> >> ejb-modeller component which doesn't have copyrights, correctly, >>> >> I believe, since it's a trivial file. >>> >> >>> >> COMPLIANCE TESTS >>> >> >>> >> The CT reports can be viewed at >>> >> http://aries.apache.org/downloads/ct/1.0.0/, and the previous set of >>> >> reports are at http://aries.apache.org/downloads/ct/0.3/ >>> >> >>> >> org.osgi.test.cases.blueprint.html:7 (5) >>> >> /org.osgi.test.cases.blueprint.java5.html:0 (0) >>> >> org.osgi.test.cases.blueprint.secure.html:0 (0) >>> >> org.osgi.test.cases.jmx.html:18 (18) >>> >> org.osgi.test.cases.jndi.html:7 (3, or 5 when run on recent Sun VMs) >>> >> org.osgi.test.cases.jndi.secure.html:0 (0) >>> >> org.osgi.test.cases.transaction.html:0 (0) >>> >> >>> >> >>> >> The vote will be open for 72 hours, closing Monday night. >>> >> >>> >> [ ] +1 >>> >> [ ] 0 >>> >> [ ] -1 >>> >> >>> > >>> > >>> > >>> > -- >>> > ------------------------ >>> > Guillaume Nodet >>> > ------------------------ >>> > Blog: http://gnodet.blogspot.com/ >>> > ------------------------ >>> > FuseSource, Integration everywhere >>> > http://fusesource.com >>
