Thanks for the update Giuseppe,
For the version range, I'm not 100% sure as the next JPA version will be
3.0.0 (not 2.2.0). So actually, both is correct.
For all updates, I'm just waiting the geronimo-jpa_2.1 release to complete.
Regards
JB
On 05/26/2014 02:54 PM, Giuseppe Gerla wrote:
Hi JB
I make a diff between your commit and my commit.
A general consideration to make is that in all pom files in the
import-package section the javax.persistence version should
be "[1.0.0,2.2.0)" and not "[1.0.0,3.0.0)".
By code point of view I see following main difference:
- In JTAEntityManager.java you force the isJoinedToTransaction methid to
return true. From my point of view is more correct following code
EntityManager em = getPersistenceContext(false);
try {
return em.isJoinedToTransaction();
} finally {
if(em == detachedManager)
em.clear();
}
- In ManagedPersistenceContextFactory.java you have implemented last five
methods in the file to force return null. I think is better to throw
UnsupportedOperationException
- In EclipseLinkProviderService.java you don't override and implement
public void generateSchema(PersistenceUnitInfo arg0, Map arg1);
public boolean generateSchema(String arg0, Map arg1);
- In the pom of jpa-container-eclipselink-adapter bundle the version of
Eclipselink is 2.1.0 but to support JPA 2.1 you have to use >= 2.5.0
(related to previous point)
- In the pom of jpa-container-testbundle-eclipselink bundle the version of
Eclipselink is 2.1.0 but to support JPA 2.1 you have to use >= 2.5.0
(related to previous point)
- In all itest bundle it is important to update the pax-exam configuration
to use geronimo-jpa_2.1_spec if you want to test new implementation
- In all itest bundle it is important to update the openjpa version to
2.2.2 and update pax-exam configuration to use this version of openjpa (we
are waiting openjpa 2.4 to support JPA 2.1)
- In the pom of jpa-container-itest bundle you can update
the org.apache.aries.blueprint.core version to 1.4.0
- In the pom of jpa-container-itest bundle you can update all aries bundle
version dependency
I hope that my explanation was clear and can help you.
Regards
Giuseppe
2014-05-26 13:55 GMT+02:00 Giuseppe Gerla <[email protected]>:
Hi JB
For now I was able to see the commit via web. I see that there are no
tests of the features of version 2.0 and 2.1.
The persistence.xml refer to JPA 1.0
xsi: schemaLocation = "http://java.sun.com/xml/ns/persistence
http://java.sun.com/xml/ns/persistence/persistence_1_0.xsd"; version =
"1.0
therefore do not test the new code implemented.
I hope to do a diff during the day to give you more feedback
Thanks
Regards
Giuseppe
2014-05-26 12:45 GMT+02:00 Jean-Baptiste Onofré <[email protected]>:
Hi Giusseppe,
I've already done JPA 2.1 support. I submitted the pull request, and we
are good. You can take a look in ARIES-1047 (the pull request is in
comment).
Regards
JB
On 05/26/2014 11:13 AM, Giuseppe Gerla wrote:
Hi all
I am very interested about the issue ARIES-1047. Please check releated
issue ARIES-1134 and my commit
https://github.com/ggerla/aries/commit/8fa3a46c3eff7abe893d3e859300c4
cf807d5490
I think that is a good start point.
regards
Giuseppe
2014-05-26 11:04 GMT+02:00 Jean-Baptiste Onofré <[email protected]>:
Thanks all guys,
I would like to commit some stuff today, but I would like your
approval/feedback:
- ARIES-1006: I refactored the parent to use Java7 and OSGi 4.3.0 by
default. I don't think it makes sense to still maintain Java5 (as it's
EOL). The current patch that I provided upgrade and compile with Java7,
but
use OSGi 4.2.0. I'm working on a new patch adding OSGi 4.3.0 support by
default. Any objection ?
- ARIES-1177: upgrade to Apache POM 14 and upgrade some dependencies.
- ARIES-1047: I've updated Aries JPA to support JPA 2.1 using
geronimo-jpa_2.1 spec. Unfortunately, geronimo-jpa_2.1 has not been
released and it's only available as a SNAPSHOT for now. I asked to
Guillaume if he can make a release, and he said, he will. So I will
commit
as soon as geronimo-jpa_2.1 is on central.
- ARIES-1180, ARIES-1179: I have a set of patches ready to upgrade to
ASM
5.0.2 and support Java8, especially in Proxy and SpiFly.
Any objection ?
By the way, on Jira, I'm not able to assign Jira to myself, or change
Jira. Can you give the permission for that please ?
Thanks !
Regards
JB
On 05/25/2014 02:55 PM, Daniel Kulp wrote:
The Aries PMC has voted in two new committers:
Jean-Baptiste Onofré
Christian Schneider
Congratulations to them and many thanks for the contributions!
--
Jean-Baptiste Onofré
[email protected]
http://blog.nanthrax.net
Talend - http://www.talend.com
--
Jean-Baptiste Onofré
[email protected]
http://blog.nanthrax.net
Talend - http://www.talend.com
--
Jean-Baptiste Onofré
[email protected]
http://blog.nanthrax.net
Talend - http://www.talend.com
