[
https://issues.apache.org/jira/browse/ARIES-1360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14706813#comment-14706813
]
Alexandre Roman commented on ARIES-1360:
----------------------------------------
I agree with John (third option).
As a subsystem provider, I don't need to bother myself with details about
importing a service when I'm declaring a custom resource.
It's not clear why I need to add this import, while I'm not using it in my
subsystem code.
I think the implementation should just make things easier for the user: if a
Subsystem-Content contains a custom resource, the ContentHandler service import
should be implicit.
> ContentHandler must be explicitely imported in SUBSYSTEM.MF
> -----------------------------------------------------------
>
> Key: ARIES-1360
> URL: https://issues.apache.org/jira/browse/ARIES-1360
> Project: Aries
> Issue Type: Bug
> Components: Subsystem
> Affects Versions: subsystem-2.0.2
> Reporter: Alexandre Roman
> Labels: easyfix
>
> A custom ContentHandler implementation is not "seen" by a scoped subsystem if
> the SUBSYSTEM.MF does not include a "Subsystem-ImportService" entry for this
> interface.
> The problem is located in CustomResources.java. The ContentHandler references
> are searched in the subsystem context. Such references should be looked up
> from the system bundle context, removing the need to import this service in
> subsystems manifest.
> {code:title=CustomResources.java}
> for(ServiceReference<ContentHandler> ref :
> subsystem.getBundleContext().getServiceReferences(ContentHandler.class,
> "(" + ContentHandler.CONTENT_TYPE_PROPERTY + "=" + type +
> ")")) {
> return ref;
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
