[
https://issues.apache.org/jira/browse/ARIES-1365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14709364#comment-14709364
]
Joel Richard commented on ARIES-1365:
-------------------------------------
[~bosschaert], thanks for the feedback. I will update the patch to not register
it with the StateConfig interface and pass it around directly.
I have written createConfiguration because otherwise the configuration does not
show up in the Apache Felix Configuration Console (and if I remember correctly
it wouldn't pick up the configuration automatically in our environment, but I
will check this again).
> ServiceState attribute notifications slow down startup/shutdown time
> considerably
> ---------------------------------------------------------------------------------
>
> Key: ARIES-1365
> URL: https://issues.apache.org/jira/browse/ARIES-1365
> Project: Aries
> Issue Type: Bug
> Components: JMX
> Affects Versions: jmx-core-1.1.3
> Environment: org.apache.felix.framework 5.0.1
> Reporter: Joel Richard
> Assignee: David Bosschaert
> Labels: performance, shutdown, startup
> Attachments:
> 0001-ARIES-1365-ServiceState-attribute-notifications-slow.patch
>
>
> Around 20% of the startup time of our Felix OSGI container is spent creating
> attribute notifications for changed services in
> ServiceState#getAttributeChangeNotification. This is so slow because for each
> notification it calls bundleContext.getAllServiceReferences to get all
> service ids.
> Here a few suggestions how this could be improved:
> - The ServiceState could maintain its own list of service ids which is
> updated according to the service events
> - The ServiceState could implement the NotificationEmitter directly and be
> aware when there are any listeners (in our case, there are mostly none).
> - Make it possible to disable the attribute change notifications with
> configuration property.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
