[ https://issues.apache.org/jira/browse/ARIES-1357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14712989#comment-14712989 ]
John Ross commented on ARIES-1357: ---------------------------------- Just to be clear, with regard to your (3), the subsystem and deployment manifests do cache the values. Adding those additional local variables mentioned in my (3), as far as I call tell, simply save two additional method calls that end up accessing the value from a hash map. The persisted manifest is not read as part of that process, which is why I have doubts about the performance impact. I would like to build a test that matches your use case for further analysis. If I create an application containing 200 features which all have the same content consisting of 25 bundles or so (i.e. many features with shared content), would that be a close approximation? > BasicSubsystem can be used by the subsystem install process a factor 6 times > faster > ----------------------------------------------------------------------------------- > > Key: ARIES-1357 > URL: https://issues.apache.org/jira/browse/ARIES-1357 > Project: Aries > Issue Type: Improvement > Components: Subsystem > Affects Versions: subsystem-core-1.2.0, subsystem-2.0.1 > Environment: linux windows java > Reporter: Bas > Assignee: John Ross > Labels: patch, performance > Fix For: subsystem-core-1.2.0, subsystem-2.0.1 > > Attachments: patch-basicsubsystem.patch, > performance-105-afterrestart.nps, subsystem-basicsubsystem-patch.txt > > > The problem was poor performance while installing a subsystem on a container > with 200+ subsystems installed. > While doing performance analyses on the subsystem install process we noticed > the BasicSubsystem is working a lot with its manifest instead of > pre-calculating data that is used a lot. > While using the pre-patch version of BasicSubsystem a subsystem install > (while having 200+ running subsystems) could take more than a minute. While > using the patched version where we pre-calculate highly used data when a new > subsystem manifest or deployment manifest is set we could bring it down to 10 > seconds. We only pre-calculated the data that was highly used. -- This message was sent by Atlassian JIRA (v6.3.4#6332)