+1 but please note that spi-fly-core/src/test/java/org/apache/aries/spifly/HeaderParserTest.java needs a license header. I do not believe the same applies to the others [1], but this is all a bit vague to me. Our release documentation [2] indicates that all JAVA and JS files should have the header, then goes on to explicitly exclude manifest files. I don't know what rules to apply to anything else.
[1] !????? spi-fly-core/src/test/resources/org/apache/aries/spifly/impl1/META-INF/services/org.apache.aries.mytest.MySPI !????? spi-fly-core/src/test/resources/org/apache/aries/spifly/impl4/META-INF/services/org.apache.aries.mytest.MySPI2 !????? spi-fly-core/src/test/resources/org/apache/aries/spifly/impl4/META-INF/services/org.apache.aries.mytest.MySPI !????? spi-fly-core/src/test/java/org/apache/aries/spifly/HeaderParserTest.java !????? spi-fly-dynamic-bundle/src/test/resources/org/apache/aries/spifly/dynamic/impl2_123/META-INF/services/org.apache.aries.mytest.MySPI !????? spi-fly-dynamic-bundle/src/test/resources/org/apache/aries/spifly/dynamic/impl1/META-INF/services/org.apache.aries.mytest.MySPI !????? spi-fly-dynamic-bundle/src/test/resources/org/apache/aries/spifly/dynamic/impl2/META-INF/services/org.apache.aries.mytest.AltSPI !????? spi-fly-dynamic-bundle/src/test/resources/org/apache/aries/spifly/dynamic/impl2/META-INF/services/org.apache.aries.mytest.MySPI !????? spi-fly-dynamic-bundle/src/test/resources/org/apache/aries/spifly/dynamic/impl5/META-INF/services/org.apache.aries.mytest.MySPI !????? spi-fly-dynamic-bundle/src/test/resources/org/apache/aries/spifly/dynamic/impl4/META-INF/services/org.apache.aries.mytest.AltSPI !????? spi-fly-dynamic-bundle/src/test/resources/org/apache/aries/spifly/dynamic/impl4/META-INF/services/org.apache.aries.mytest.MySPI !????? spi-fly-dynamic-bundle/src/test/resources/org/apache/aries/spifly/dynamic/impl3/META-INF/services/javax.xml.parsers.DocumentBuilderFactory !????? spi-fly-examples/spi-fly-example-provider2-bundle/src/main/resources/META-INF/services/org.apache.aries.spifly.mysvc.SPIProvider !????? spi-fly-examples/spi-fly-example-provider1-jar/src/main/resources/META-INF/services/org.apache.aries.spifly.mysvc.SPIProvider !????? spi-fly-examples/spi-fly-example-resource-provider-bundle/src/main/resources/org/apache/aries/spifly/test/blah.txt [2] http://aries.apache.org/development/releasingaries.html On Fri, Oct 16, 2015 at 8:56 AM, <[email protected]> wrote: > Hi, > > I'm calling a vote on SPI-Fly 1.0.4. > > The following bug has been fixed: > ARIES-953 SPI-Consumer breaks when method has multiple parameters > > This release includes the following modules: > > spi-fly-core > spi-fly-dynamic-bundle > spi-fly-examples > spi-fly-static-bundle > spi-fly-static-tool > spi-fly-weaver > > Staging repository: > https://repository.apache.org/content/repositories/orgapachearies-1044 > > You can use this UNIX script to download the release and verify the > signatures: > https://svn.apache.org/repos/asf/aries/scripts/verify_staged_release.sh > > Usage: > sh verify_staged_release.sh 1044 tmpdir 2>&1 | tee verifyresults.txt > grep FAIL verifyresults.txt > grep ERROR verifyresults.txt > > More details on verifying the release here: > http://aries.apache.org/development/verifyingrelease.html > > Please vote: > +1 Approve the release > -1 Do not approve the release (please explain why) > > This vote will be open for at least 72 hours. > > Best regards, > > David Bosschaert
