[
https://issues.apache.org/jira/browse/ARIES-1564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15327373#comment-15327373
]
John Ross commented on ARIES-1564:
----------------------------------
The point of the ArrayList to LinkedList change in StartAction is not obvious
to me. How did this one change affect the results?
The key of the map would have to be more than just the symbolic name. It's the
combination of symbolic name, version, and type that makes it unique.
When getting values from the map, the key currently being used would always be
"osgi.identity" which wouldn't exist. So it looks like the proposed change is
always returning a start order of 0.
Please note that any improvements would be applied to trunk and released from
there as part of ARIES-1547.
> Performance improvement: sorting bundles by start-level is done eagerly
> -----------------------------------------------------------------------
>
> Key: ARIES-1564
> URL: https://issues.apache.org/jira/browse/ARIES-1564
> Project: Aries
> Issue Type: Improvement
> Components: Subsystem
> Affects Versions: subsystem-2.0.8
> Reporter: Wouter Bancken
>
> h4. Description
> During sorting in the StartAction class, the SubsystemContentHeader is parsed
> every time the start order of a bundle is needed. By eagerly parsing the
> header and storing the start value for every bundle, an improved startup time
> can be achieved.
> h4. Pull request
> https://github.com/apache/aries/compare/subsystem-2.0.x...WouterBanckenACA:sorting_performance_optimalisation
> h4. Mailinglist
> http://mail-archives.apache.org/mod_mbox/aries-user/201606.mbox/%3CCAL5nZgRQcvFqz8g1c7mKJ3C_UoRmRox10%2BOM2uEjRbCkTYodDQ%40mail.gmail.com%3E
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
