[ 
https://issues.apache.org/jira/browse/ARIES-1565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15419596#comment-15419596
 ] 

Wouter Bancken edited comment on ARIES-1565 at 8/12/16 10:29 PM:
-----------------------------------------------------------------

[[email protected]]
Good to know there were actual errors and it wasn't an issue on my part when 
running the tests. It was my first change to the Aries codebase so I wasn't 
sure. 

As for the error, I'd suggest you take the lead on this? We included the change 
in subsystems to avoid touching utils as you suggested. Avoiding the import 
package seems possible on first sight but it means we'll be including more code 
of utils in subsystems and I don't know if that's desirable.


was (Author: wouter bancken):
[[email protected]]
Good to know there were actual errors and it wasn't an issue on my part. It was 
my first change to the Aries codebase so I wasn't sure. 

As for the error, I'd suggest you take the lead on this? We included the change 
in subsystems to avoid touching utils as you suggested. Avoiding the import 
package seems possible on first sight but it means we'll be including more code 
of utils in subsystems and I don't know if that's desirable.

> Performance Improvement: unpack subsystem artifacts to tmp folder to avoid 
> directly reading from zip archive
> ------------------------------------------------------------------------------------------------------------
>
>                 Key: ARIES-1565
>                 URL: https://issues.apache.org/jira/browse/ARIES-1565
>             Project: Aries
>          Issue Type: Improvement
>          Components: Subsystem, Util
>    Affects Versions: subsystem-2.0.8, util-1.1.2
>            Reporter: Wouter Bancken
>         Attachments: 1565.patch, Call_Tree_2_0_8.html, 
> Call_Tree_John_Ross.html, Call_Tree_Wouter_Bancken.html, 
> aries1565-profile.png, test-service-subsystem-4.0.2-SNAPSHOT.esa
>
>
> h4. Description
> Aries copies ESA archives to a temporary zip file during the installation 
> phase. Afterwards, bundles are read directly from this temporary zip which 
> has a large impact on the startup performance of Aries applications. By 
> unpacking the esa artifact into the temporary folder it is unpacked only 
> once. Subsequent reads for the bundles (jars) can be read directly from the 
> folder. 
> h4. Pull request
> https://github.com/apache/aries/compare/subsystem-2.0.x...WouterBanckenACA:io_performance_optimalisation?expand=1
> h4. Mailinglist
> http://mail-archives.apache.org/mod_mbox/aries-user/201606.mbox/%3CCAL5nZgTq5FxDvURJbzcEZ9YHx6vTs3HAOuFYDYA3ec9OZbmwjA%40mail.gmail.com%3E



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to