I did not specifically run rat tests. To be honest I thought they were part of the apache parent so I did not check.
I added rat checks to the build on master now and fixed the reported files. Can you review this? Christian 2018-04-29 11:56 GMT+02:00 Timothy Ward <[email protected]>: > Hi Christian, > > Did you run RAT checks on this before you staged it? I am seeing the > following, which includes a lot of source files with no license headers. > All the pom files, bnd files, xsd files, and definitely the .java files > should have ASL v2 headers. Some of these are long-standing files, so > they’ve clearly been released several times without headers. > > This is the output I see: > > ./repository/target/rat.txt: !????? /Users/timothyjward/ > development/apache/verify/mytempdirectory/1126-unzips/ > org.apache.aries.rsa.main-1.12.0/repository/pom.xml > ./itests/target/rat.txt: !????? /Users/timothyjward/ > development/apache/verify/mytempdirectory/1126-unzips/ > org.apache.aries.rsa.main-1.12.0/itests/tck/install/install-tests.sh > ./itests/target/rat.txt: !????? /Users/timothyjward/ > development/apache/verify/mytempdirectory/1126-unzips/ > org.apache.aries.rsa.main-1.12.0/itests/tck/tck.bndrun > ./itests/target/rat.txt: !????? /Users/timothyjward/ > development/apache/verify/mytempdirectory/1126-unzips/ > org.apache.aries.rsa.main-1.12.0/itests/tck/README.md > ./target/rat.txt: !????? DEPENDENCIES > ./target/rat.txt: !????? Readme.md > ./eapub/target/rat.txt: !????? /Users/timothyjward/ > development/apache/verify/mytempdirectory/1126-unzips/ > org.apache.aries.rsa.main-1.12.0/eapub/pom.xml > ./eapub/target/rat.txt: !????? /Users/timothyjward/ > development/apache/verify/mytempdirectory/1126-unzips/ > org.apache.aries.rsa.main-1.12.0/eapub/Readme.md > ./eapub/target/rat.txt: !????? /Users/timothyjward/ > development/apache/verify/mytempdirectory/1126-unzips/ > org.apache.aries.rsa.main-1.12.0/eapub/bnd.bnd > ./rsa/target/rat.txt: !????? /Users/timothyjward/ > development/apache/verify/mytempdirectory/1126-unzips/ > org.apache.aries.rsa.main-1.12.0/rsa/pom.xml > ./rsa/target/rat.txt: !????? /Users/timothyjward/ > development/apache/verify/mytempdirectory/1126-unzips/ > org.apache.aries.rsa.main-1.12.0/rsa/Readme.md > ./rsa/target/rat.txt: !????? /Users/timothyjward/ > development/apache/verify/mytempdirectory/1126-unzips/ > org.apache.aries.rsa.main-1.12.0/rsa/bnd.bnd > ./rsa/target/rat.txt: !????? /Users/timothyjward/ > development/apache/verify/mytempdirectory/1126-unzips/ > org.apache.aries.rsa.main-1.12.0/rsa/src/main/java/org/ > apache/aries/rsa/core/event/EventAdminSender.java > ./features/target/rat.txt: !????? /Users/timothyjward/ > development/apache/verify/mytempdirectory/1126-unzips/ > org.apache.aries.rsa.main-1.12.0/features/src/main/resources/features.xml > ./discovery/config/target/rat.txt: !????? /Users/timothyjward/ > development/apache/verify/mytempdirectory/1126-unzips/ > org.apache.aries.rsa.main-1.12.0/discovery/config/Readme.md > ./discovery/config/target/rat.txt: !????? /Users/timothyjward/ > development/apache/verify/mytempdirectory/1126-unzips/ > org.apache.aries.rsa.main-1.12.0/discovery/config/bnd.bnd > ./discovery/zookeeper/target/rat.txt: !????? /Users/timothyjward/ > development/apache/verify/mytempdirectory/1126-unzips/ > org.apache.aries.rsa.main-1.12.0/discovery/zookeeper/Readme.md > ./discovery/zookeeper/target/rat.txt: !????? /Users/timothyjward/ > development/apache/verify/mytempdirectory/1126-unzips/ > org.apache.aries.rsa.main-1.12.0/discovery/zookeeper/bnd.bnd > ./discovery/zookeeper/target/rat.txt: !????? /Users/timothyjward/ > development/apache/verify/mytempdirectory/1126-unzips/ > org.apache.aries.rsa.main-1.12.0/discovery/zookeeper/src/ > test/java/org/apache/aries/rsa/discovery/zookeeper/repository/ > ZookeeperEndpointRepositoryTest.java > ./discovery/zookeeper/target/rat.txt: !????? /Users/timothyjward/ > development/apache/verify/mytempdirectory/1126-unzips/ > org.apache.aries.rsa.main-1.12.0/discovery/zookeeper/src/ > test/java/org/apache/aries/rsa/discovery/zookeeper/ > ZookeeperDiscoveryTest.java > ./discovery/zookeeper/target/rat.txt: !????? /Users/timothyjward/ > development/apache/verify/mytempdirectory/1126-unzips/ > org.apache.aries.rsa.main-1.12.0/discovery/zookeeper/src/ > main/java/org/apache/aries/rsa/discovery/zookeeper/repository/ > ZookeeperEndpointRepository.java > ./discovery/local/target/rat.txt: !????? /Users/timothyjward/ > development/apache/verify/mytempdirectory/1126-unzips/ > org.apache.aries.rsa.main-1.12.0/discovery/local/Readme.md > ./discovery/local/target/rat.txt: !????? /Users/timothyjward/ > development/apache/verify/mytempdirectory/1126-unzips/ > org.apache.aries.rsa.main-1.12.0/discovery/local/bnd.bnd > ./discovery/local/target/rat.txt: !????? /Users/timothyjward/ > development/apache/verify/mytempdirectory/1126-unzips/ > org.apache.aries.rsa.main-1.12.0/discovery/local/src/test/ > resources/ed2.xml > ./discovery/local/target/rat.txt: !????? /Users/timothyjward/ > development/apache/verify/mytempdirectory/1126-unzips/ > org.apache.aries.rsa.main-1.12.0/discovery/local/src/test/ > resources/ed2-generated.xml > ./discovery/local/target/rat.txt: !????? /Users/timothyjward/ > development/apache/verify/mytempdirectory/1126-unzips/ > org.apache.aries.rsa.main-1.12.0/discovery/local/src/main/ > resources/endpoint-description.xsd > ./discovery/command/target/rat.txt: !????? /Users/timothyjward/ > development/apache/verify/mytempdirectory/1126-unzips/ > org.apache.aries.rsa.main-1.12.0/discovery/command/Readme.md > ./discovery/command/target/rat.txt: !????? /Users/timothyjward/ > development/apache/verify/mytempdirectory/1126-unzips/ > org.apache.aries.rsa.main-1.12.0/discovery/command/bnd.bnd > ./provider/fastbin/target/rat.txt: !????? /Users/timothyjward/ > development/apache/verify/mytempdirectory/1126-unzips/ > org.apache.aries.rsa.main-1.12.0/provider/fastbin/pom.xml > ./provider/fastbin/target/rat.txt: !????? /Users/timothyjward/ > development/apache/verify/mytempdirectory/1126-unzips/ > org.apache.aries.rsa.main-1.12.0/provider/fastbin/Readme.md > ./provider/fastbin/target/rat.txt: !????? /Users/timothyjward/ > development/apache/verify/mytempdirectory/1126-unzips/ > org.apache.aries.rsa.main-1.12.0/provider/fastbin/bnd.bnd > ./provider/tcp/target/rat.txt: !????? /Users/timothyjward/ > development/apache/verify/mytempdirectory/1126-unzips/ > org.apache.aries.rsa.main-1.12.0/provider/tcp/pom.xml > ./provider/tcp/target/rat.txt: !????? /Users/timothyjward/ > development/apache/verify/mytempdirectory/1126-unzips/ > org.apache.aries.rsa.main-1.12.0/provider/tcp/Readme.md > ./provider/tcp/target/rat.txt: !????? /Users/timothyjward/ > development/apache/verify/mytempdirectory/1126-unzips/ > org.apache.aries.rsa.main-1.12.0/provider/tcp/bnd.bnd > ./provider/tcp/target/rat.txt: !????? /Users/timothyjward/ > development/apache/verify/mytempdirectory/1126-unzips/ > org.apache.aries.rsa.main-1.12.0/provider/tcp/src/test/ > java/org/apache/aries/rsa/provider/tcp/myservice/PrimitiveServiceImpl.java > ./provider/tcp/target/rat.txt: !????? /Users/timothyjward/ > development/apache/verify/mytempdirectory/1126-unzips/ > org.apache.aries.rsa.main-1.12.0/provider/tcp/src/test/ > java/org/apache/aries/rsa/provider/tcp/myservice/ > ExpectedTestException.java > ./provider/tcp/target/rat.txt: !????? /Users/timothyjward/ > development/apache/verify/mytempdirectory/1126-unzips/ > org.apache.aries.rsa.main-1.12.0/provider/tcp/src/test/ > java/org/apache/aries/rsa/provider/tcp/TcpEndpointTest.java > ./provider/tcp/target/rat.txt: !????? /Users/timothyjward/ > development/apache/verify/mytempdirectory/1126-unzips/ > org.apache.aries.rsa.main-1.12.0/provider/tcp/src/main/ > java/org/apache/aries/rsa/provider/tcp/ser/VersionMarker.java > ./provider/tcp/target/rat.txt: !????? /Users/timothyjward/ > development/apache/verify/mytempdirectory/1126-unzips/ > org.apache.aries.rsa.main-1.12.0/provider/tcp/src/main/ > java/org/apache/aries/rsa/provider/tcp/ser/DTOMarker.java > ./provider/tcp/target/rat.txt: !????? /Users/timothyjward/ > development/apache/verify/mytempdirectory/1126-unzips/ > org.apache.aries.rsa.main-1.12.0/provider/tcp/src/main/ > java/org/apache/aries/rsa/provider/tcp/ser/BasicObjectOutputStream.java > ./spi/target/rat.txt: !????? /Users/timothyjward/ > development/apache/verify/mytempdirectory/1126-unzips/ > org.apache.aries.rsa.main-1.12.0/spi/bnd.bnd > ./examples/echotcp/target/rat.txt: !????? /Users/timothyjward/ > development/apache/verify/mytempdirectory/1126-unzips/ > org.apache.aries.rsa.main-1.12.0/examples/echotcp/Readme.md > ./examples/echotcp/api/target/rat.txt: !????? /Users/timothyjward/ > development/apache/verify/mytempdirectory/1126-unzips/ > org.apache.aries.rsa.main-1.12.0/examples/echotcp/api/pom.xml > ./examples/echotcp/api/target/rat.txt: !????? /Users/timothyjward/ > development/apache/verify/mytempdirectory/1126-unzips/ > org.apache.aries.rsa.main-1.12.0/examples/echotcp/api/bnd.bnd > ./examples/echotcp/api/target/rat.txt: !????? /Users/timothyjward/ > development/apache/verify/mytempdirectory/1126-unzips/ > org.apache.aries.rsa.main-1.12.0/examples/echotcp/api/src/ > main/java/org/apache/aries/rsa/examples/echotcp/api/EchoService.java > ./examples/echotcp/consumer/target/rat.txt: !????? /Users/timothyjward/ > development/apache/verify/mytempdirectory/1126-unzips/ > org.apache.aries.rsa.main-1.12.0/examples/echotcp/consumer/bnd.bnd > ./examples/echotcp/service/target/rat.txt: !????? /Users/timothyjward/ > development/apache/verify/mytempdirectory/1126-unzips/ > org.apache.aries.rsa.main-1.12.0/examples/echotcp/service/bnd.bnd > ./examples/echotcp/service/target/rat.txt: !????? /Users/timothyjward/ > development/apache/verify/mytempdirectory/1126-unzips/ > org.apache.aries.rsa.main-1.12.0/examples/echotcp/service/ > src/main/java/org/apache/aries/rsa/examples/echotcp/ > service/EchoServiceImpl.java > ./examples/echofastbin/target/rat.txt: !????? /Users/timothyjward/ > development/apache/verify/mytempdirectory/1126-unzips/ > org.apache.aries.rsa.main-1.12.0/examples/echofastbin/Readme.md > ./examples/echofastbin/fbconsumer/target/rat.txt: !????? > /Users/timothyjward/development/apache/verify/mytempdirectory/1126-unzips/ > org.apache.aries.rsa.main-1.12.0/examples/echofastbin/fbconsumer/bnd.bnd > ./examples/echofastbin/fbservice/target/rat.txt: !????? > /Users/timothyjward/development/apache/verify/mytempdirectory/1126-unzips/ > org.apache.aries.rsa.main-1.12.0/examples/echofastbin/fbservice/bnd.bnd > ./examples/echofastbin/fbservice/target/rat.txt: !????? > /Users/timothyjward/development/apache/verify/mytempdirectory/1126-unzips/ > org.apache.aries.rsa.main-1.12.0/examples/echofastbin/ > fbservice/src/main/java/org/apache/aries/rsa/examples/fastbin/service/ > EchoServiceImpl.java > ./examples/echofastbin/fbapi/target/rat.txt: !????? /Users/timothyjward/ > development/apache/verify/mytempdirectory/1126-unzips/ > org.apache.aries.rsa.main-1.12.0/examples/echofastbin/fbapi/pom.xml > ./examples/echofastbin/fbapi/target/rat.txt: !????? /Users/timothyjward/ > development/apache/verify/mytempdirectory/1126-unzips/ > org.apache.aries.rsa.main-1.12.0/examples/echofastbin/fbapi/bnd.bnd > ./examples/echofastbin/fbapi/target/rat.txt: !????? /Users/timothyjward/ > development/apache/verify/mytempdirectory/1126-unzips/ > org.apache.aries.rsa.main-1.12.0/examples/echofastbin/ > fbapi/src/main/java/org/apache/aries/rsa/examples/ > fastbin/api/EchoService.java > ./topology-manager/target/rat.txt: !????? /Users/timothyjward/ > development/apache/verify/mytempdirectory/1126-unzips/ > org.apache.aries.rsa.main-1.12.0/topology-manager/Readme.md > ./topology-manager/target/rat.txt: !????? /Users/timothyjward/ > development/apache/verify/mytempdirectory/1126-unzips/ > org.apache.aries.rsa.main-1.12.0/topology-manager/bnd.bnd > ./topology-manager/target/rat.txt: !????? /Users/timothyjward/ > development/apache/verify/mytempdirectory/1126-unzips/ > org.apache.aries.rsa.main-1.12.0/topology-manager/src/ > main/java/org/apache/aries/rsa/topologymanager/importer/local/Readme.md > ./topology-manager/target/rat.txt: !????? /Users/timothyjward/ > development/apache/verify/mytempdirectory/1126-unzips/ > org.apache.aries.rsa.main-1.12.0/topology-manager/src/ > main/java/org/apache/aries/rsa/topologymanager/ > EndpointEventListenerTracker.java > > > > On 29 Apr 2018, at 08:48, Christian Schneider <[email protected]< > mailto:[email protected]>> wrote: > > I am sorry. Seems I used the wrong URL. > > This is the correct one: > https://repository.apache.org/content/repositories/orgapachearies-1126 > > Best, > Christian > > 2018-04-27 20:29 GMT+02:00 Tim Ward <[email protected]<mailto:t > [email protected]>>: > > Hi Christian - I’m not able to verify the release because I can’t access > the staging repo. Did you remember to close it? > > Thanks, > > Tim > > On 27 Apr 2018, at 13:08, David Bosschaert <[email protected]< > mailto:[email protected]>> > wrote: > > +1 > > David > > On 27 April 2018 at 09:31, Christian Schneider <[email protected]< > mailto:[email protected]>> > wrote: > > This release of Aries RSA is the reference implementation of Remote > Services and Remote Service Admin from the OSGi R7 spec. It was tested > against the TCK and passes all tests. > > See here for the specs we implement: > https://osgi.org/specification/osgi.cmpn/7.0.0/service. > remoteservices.html > https://osgi.org/specification/osgi.cmpn/7.0.0/service. > remoteserviceadmin. > html > > Keep in mind though that at the moment only the TCP transport fully > supports the new spec. > > Some highlights are: > > - Support for async return types like: Future, > CompletableFuture, CompletionStage, Promises > - Can transport all primitive types including the OSGi DTO types > - Zookeeper discovery now creates a lot less nodes and needs only one > listener > > I've staged the release at > > https://repository.apache.org/content/repositories/orgapachearies-1113/ > > For a list of issues resolved see: > > https://issues.apache.org/jira/projects/ARIES/versions/12341022 > > > Release Notes - Aries - Version rsa-1.12.0 > > ** Bug > * [ARIES-1759] - Fastbin fails to bind if a configuration exists with > the same port > * [ARIES-1760] - Primitive type do not work as parameters in TCP > transport > * [ARIES-1763] - Upgrade capabilities and API for remote service > admin > 1.1.0 spec > > > ** New Feature > * [ARIES-1756] - Support osgi.basic.timeout > * [ARIES-1757] - Implement osgi.async intent > * [ARIES-1758] - Support osgi.basic intent > * [ARIES-1764] - Also send events using eventadmin > > > ** Improvement > * [ARIES-1769] - Make sure services with unsupported intents are not > exported > * [ARIES-1771] - Support modification events > * [ARIES-1774] - Refactor Zookeeper discovery to use only one > listener > for all zk endpoints > * [ARIES-1775] - Remove DiscoveryPlugin > * [ARIES-1776] - Fixes for tck secure tests > * [ARIES-1778] - Use endpoint id as path in zookeeper > > > Please review and vote > > Here is my > +1 > > -- > -- > Christian Schneider > http://www.liquid-reality.de > > Computer Scientist > http://www.adobe.com > > > > > > -- > -- > Christian Schneider > http://www.liquid-reality.de > > Computer Scientist > http://www.adobe.com > > > > > -- > -- > Christian Schneider > http://www.liquid-reality.de<http://www.liquid-reality.de/> > > Computer Scientist > http://www.adobe.com<http://www.adobe.com/> > > -- -- Christian Schneider http://www.liquid-reality.de Computer Scientist http://www.adobe.com
