[
https://issues.apache.org/jira/browse/ARIES-1800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16467238#comment-16467238
]
ASF GitHub Bot commented on ARIES-1800:
---------------------------------------
GitHub user Smasherr opened a pull request:
https://github.com/apache/aries/pull/83
ARIES-1800: Collect exceptions from class level annotations
The commit fixes the bug and adds a test
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Smasherr/aries ARIES-1800
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/aries/pull/83.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #83
----
commit 54e025bc0b92ff2695f503b0ddd49d539b1f0de5
Author: Daniel Estermann <d.estermann@...>
Date: 2018-05-08T09:28:06Z
ARIES-1800: Collect exceptions from class level annotations
----
> rollbackOn element of Transactional annotation ignored when set on class level
> ------------------------------------------------------------------------------
>
> Key: ARIES-1800
> URL: https://issues.apache.org/jira/browse/ARIES-1800
> Project: Aries
> Issue Type: Bug
> Components: Transaction
> Affects Versions: transaction-blueprint-2.2.0
> Reporter: Daniel Estermann
> Priority: Major
>
> Since ARIES-1690 the methods throwing a checked exception cause a rollback if
> the related exception is marked for a rollback using rollbackOn element of
> Transactional annotation set on a method. However this doesn't work for
> Transactional annotations on the class level.
> We also need to clarify how we should handle a exceptions set on both levels
> class and method. There are at least two options:
> * The resulting set of exceptions marked for rollback is an aggregation from
> both class level and method level annotation.
> * Exception set defined on the method level overrides exceptions of the class
> leve.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)