Looks cool!
Couple points:
- you could avoid `-exportcontents: ${packages;VERSIONED}` by using @
org.osgi.annotation.bundle.Export
- you could avoid having to write your own @BeanPropertyTypes for Http
Whiteboard properties by using this dependency:
<dependency>
<groupId>org.apache.aries.cdi</groupId>
<artifactId>org.apache.aries.cdi.extra</artifactId>
<version>1.0.2</version>
</dependency>
It contains clones of all the known ComponentPropertyTypes for use in CDI.
Might save you a some lines of code.
Otherwise it looks really nice! :D
Now tell me, how was your experience using CDI? (merely intended to get
rational feedback ;) )
- Ray
On Thu, Sep 5, 2019 at 1:40 PM Carsten Ziegeler <[email protected]>
wrote:
> Sure: https://github.com/cziegeler/features.cdi
>
> it even has a readme with instructions :)
>
> Regards
> Carsten
>
> Am 05.09.2019 um 16:36 schrieb Raymond Auge:
> > Cool! Do you have a link to the project repo so we can have a look?
> >
> > - Ray
> >
> > On Thu, Sep 5, 2019 at 1:18 AM Carsten Ziegeler <[email protected]>
> > wrote:
> >
> >> Just as a follow-up, I got it running and created a project using Apache
> >> Sling's implementation of a feature model which is used to drive
> >> RFC 241 : https://github.com/osgi/design/tree/master/rfcs/rfc0241
> >>
> >> Regards
> >> Carstne
> >>
> >> Am 26.07.2019 um 17:46 schrieb Carsten Ziegeler:
> >>> Thanks Ray, I'll give it a try
> >>>
> >>>
> >>> Carsten
> >>>
> >>>
> >>> Raymond Auge wrote
> >>>> Here's a less complex example doing the same thing [1].
> >>>>
> >>>> - Ray
> >>>>
> >>>> [1]
> >>>>
> >>
> https://github.com/rotty3000/com.github.rotty3000.examples/blob/master/com.github.rotty3000.cdi.servlet/pom.xml
> >>>>
> >>>>
> >>>> On Fri, Jul 26, 2019 at 10:59 AM Raymond Auge <
> [email protected]
> >>>
> >>>> wrote:
> >>>>
> >>>>> The maven BOM for CDI should have everything since I use it to
> resolve
> >>>>> outside of the CDI project [1].
> >>>>>
> >>>>> - Ray
> >>>>>
> >>>>> [1]
> >>>>>
> >>
> https://github.com/rotty3000/com.github.rotty3000.examples/blob/master/com.github.rotty3000.cdi.jaxrs/pom.xml#L188-L194
> >>>>>
> >>>>>
> >>>>> On Fri, Jul 26, 2019 at 10:57 AM Carsten Ziegeler <
> >> [email protected]>
> >>>>> wrote:
> >>>>>
> >>>>>> Yes, but the maven pom does not have everything.
> >>>>>>
> >>>>>>
> >>>>>> I'll continue fiddling around then
> >>>>>>
> >>>>>>
> >>>>>> Thanks
> >>>>>>
> >>>>>> Carsten
> >>>>>>
> >>>>>>
> >>>>>> Raymond Auge wrote
> >>>>>>> Also there's a maven BOM [1] that contains all the deps.
> >>>>>>>
> >>>>>>> - Ray
> >>>>>>>
> >>>>>>> [1]
> >>>>>>>
> >>>>>>
> >>
> https://repo1.maven.org/maven2/org/apache/aries/cdi/org.apache.aries.cdi.bom/1.0.2/org.apache.aries.cdi.bom-1.0.2.pom
> >>>>>>
> >>>>>>>
> >>>>>>> On Fri, Jul 26, 2019 at 10:51 AM Raymond Auge
> >>>>>>> <[email protected]
> >>>>>>>
> >>>>>>> wrote:
> >>>>>>>
> >>>>>>>> You mean this [1]?
> >>>>>>>> If you looked at the README [2]
> >>>>>>>>
> >>>>>>>> tldr; The default build produces an executable jar that contains
> all
> >>>>>> the
> >>>>>>>> bundles needed.
> >>>>>>>>
> >>>>>>>> - Ray
> >>>>>>>>
> >>>>>>>> [1]
> >>>>>>>>
> >>>>>>
> >>
> https://github.com/apache/aries-cdi/blob/master/cdi-executable/executable.bndrun#L34-L69
> >>>>>>
> >>>>>>>> [2]
> >>>>>>>>
> >>>>>>
> >>
> https://github.com/apache/aries-cdi/blob/master/README.md#pre-built-runtime
> >>>>>>
> >>>>>>>>
> >>>>>>>> On Fri, Jul 26, 2019 at 10:23 AM Carsten Ziegeler <
> >>>>>> [email protected]>
> >>>>>>>> wrote:
> >>>>>>>>
> >>>>>>>>> Hi
> >>>>>>>>>
> >>>>>>>>> I tried to get the CDI extender running, tried to figure out
> which
> >>>>>>>>> bundles are required by transitively looking at the
> >>>>>> imports/requirements.
> >>>>>>>>> But so far I failed to get it running.
> >>>>>>>>>
> >>>>>>>>> Now, instead of me reporting what I did, I'm sure there are
> people
> >>>>>> here
> >>>>>>>>> who have it running. So is there some minimal list of bundles
> >>>>>>>>> required
> >>>>>>>>> to run the CDI extender?
> >>>>>>>>>
> >>>>>>>>> Thanks
> >>>>>>>>> Carsten
> >>>>>>>>> --
> >>>>>>>>> Carsten Ziegeler
> >>>>>>>>> Adobe Research Switzerland
> >>>>>>>>> [email protected]
> >>>>>>>>>
> >>>>>>>>
> >>>>>>>>
> >>>>>>>> --
> >>>>>>>> *Raymond Augé* <http://www.liferay.com/web/raymond.auge/profile>
> >>>>>>>> (@rotty3000)
> >>>>>>>> Senior Software Architect *Liferay, Inc.* <http://www.liferay.com
> >
> >>>>>>>> (@Liferay)
> >>>>>>>> Board Member & EEG Co-Chair, OSGi Alliance <http://osgi.org>
> >>>>>>>> (@OSGiAlliance)
> >>>>>>>>
> >>>>>>>
> >>>>>>>
> >>>>>> --
> >>>>>> Carsten Ziegeler
> >>>>>> Adobe Research Switzerland
> >>>>>> [email protected]
> >>>>>>
> >>>>>
> >>>>>
> >>>>> --
> >>>>> *Raymond Augé* <http://www.liferay.com/web/raymond.auge/profile>
> >>>>> (@rotty3000)
> >>>>> Senior Software Architect *Liferay, Inc.* <http://www.liferay.com>
> >>>>> (@Liferay)
> >>>>> Board Member & EEG Co-Chair, OSGi Alliance <http://osgi.org>
> >>>>> (@OSGiAlliance)
> >>>>>
> >>>>
> >>>>
> >>> --
> >>> Carsten Ziegeler
> >>> Adobe Research Switzerland
> >>> [email protected]
> >>
> >> --
> >> --
> >> Carsten Ziegeler
> >> Adobe Research Switzerland
> >> [email protected]
> >>
> >
> >
>
> --
> --
> Carsten Ziegeler
> Adobe Research Switzerland
> [email protected]
>
--
*Raymond Augé* <http://www.liferay.com/web/raymond.auge/profile>
(@rotty3000)
Senior Software Architect *Liferay, Inc.* <http://www.liferay.com>
(@Liferay)
