timothyjward commented on a change in pull request #133:
URL:
https://github.com/apache/aries-jax-rs-whiteboard/pull/133#discussion_r728723988
##########
File path:
jax-rs.whiteboard/src/main/java/org/apache/aries/jax/rs/whiteboard/internal/client/ClientBuilderImpl.java
##########
@@ -19,9 +19,6 @@
import
org.apache.aries.jax.rs.whiteboard.cxf.jaxrs.client.PromiseRxInvokerProviderImpl;
-import aQute.bnd.annotation.spi.ServiceProvider;
-
-@ServiceProvider(javax.ws.rs.client.ClientBuilder.class)
Review comment:
> Further, I'm not questioning the need to fix the bug. I just don't
want to break existing behaviours.
Well we should definitely include the additional tests for static methods
then! 😄
I've played around with the service loader capabilities and I have managed
to get them used, but not registered as services. This lets the lifecycle tests
pass, and leaves `ProvidersTest` from your PR in the same state as before (one
failure for SSE).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
