gnodet commented on code in PR #151:
URL: https://github.com/apache/aries/pull/151#discussion_r848151091
##########
transaction/transaction-blueprint/src/main/java/org/apache/aries/transaction/TxInterceptorImpl.java:
##########
@@ -61,7 +62,18 @@ public Object preCall(ComponentMetadata cm, Method m,
Object... parameters) thro
LOGGER.debug("PreCall for bean {}, method {} with tx strategy {}.",
getCmId(cm), m.getName(), txAttribute);
TransactionToken token = txAttribute.begin(tm);
- if (token.requiresNewCoordination()) {
+ boolean requiresNewCoordination = token.requiresNewCoordination();
+ if (!requiresNewCoordination && !transactionExists(coordinator)) {
+ // in case the txAttribute doesn't require new coordination AND
there's active transaction, like in:
+ // - REQUIURED, when there was TX active before the method
Review Comment:
typo in `REQUIURED` ...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
