alien11689 commented on code in PR #296: URL: https://github.com/apache/aries/pull/296#discussion_r1863781179
########## jmx/jmx-mbeanserver-platform/src/main/java/org/apache/aries/jmx/mbean_server/platform/impl/Activator.java: ########## @@ -0,0 +1,72 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.aries.jmx.mbean_server.platform.impl; + +import java.lang.management.ManagementFactory; +import java.util.Hashtable; + +import javax.management.Attribute; +import javax.management.AttributeList; +import javax.management.MBeanServer; +import javax.management.ObjectName; + +import org.osgi.framework.BundleActivator; +import org.osgi.framework.BundleContext; +import org.osgi.framework.ServiceRegistration; + +public class Activator implements BundleActivator { + + private final Object registrationLock = new Object(); + private ServiceRegistration<MBeanServer> registration; + + @Override + public void start(BundleContext context) throws Exception { Review Comment: I was able to have green build locally with some hacky way... ``` $ rm -r ~/.m2/repository/ $ git llog | head -5 662919507 2024-11-26 16:45:57 +0100 Christian Schneider (HEAD -> trunk, origin/trunk, origin/HEAD) Merge pull request #295 from rombert/fix/jmx-parent-update 7ad81cb47 2024-11-26 15:41:01 +0100 Robert Munteanu jmx: use Aries parent 2.1.1 e93c8014b 2023-11-14 22:16:29 +0100 Guillaume Nodet Fix javadoc aea7d9056 2023-11-07 20:56:47 +0100 JB Onofré [maven-release-plugin] prepare for next development iteration e9086cbe9 2023-11-07 20:56:32 +0100 JB Onofré (tag: spifly-1.3.7) [maven-release-plugin] prepare release spifly-1.3.7 $ mvn -pl jmx/jmx-itests clean install ... $ git checkout e93c8014b ... $ mvn -am -pl jmx/jmx-bundle clean install ... $ git checkout trunk ... # update pax url to 2.5.3 in itest pom.xml ... $ mvn -pl jmx/jmx-itests clean install # note: no -am ``` It looks like jmx-bundle built with newer parent makes the tests fail. I see the only one significant difference in jmx-bundle jars - ``` Require-Capability: osgi.ee;filter:="(&(osgi.ee=JavaSE)(version=1.6))" ``` is changed to ``` Require-Capability: osgi.ee;filter:="(&(osgi.ee=JavaSE)(version=1.8))" ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@aries.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
