Hi Dominik Let me do a new pass. I thought that web depends to proxy, but I was confused.
For proxy, yes, I will take a look as it's a direct dep for blueprint too. I will keep you posted. Thanks ! Regards JB On Wed, Feb 5, 2025 at 11:26 PM Dominik Przybysz <alien11...@apache.org> wrote: > > Hi team, > I posted some reviews where team feedback would be valueble: > > https://github.com/apache/aries/pull/413 - Aries Web update to support java > 11, 17 and 21. Especially JB Onofré declared the will to review because of > used Proxy, but I found that proxy is not a real dependency there so I > removed its usage in Web submodule. > > https://github.com/apache/aries/pull/415 - Equinox changed the way how > custom URLs are handled in minor version 3.17 blocking upgrade to the > newest 3.22 in tests (details in > https://issues.apache.org/jira/browse/ARIES-2166), Let me know if you are > ok with this change. > > https://github.com/apache/aries/pull/414 - Aries Proxy update to support > java 11, 17 and 21. Because of sun classes removal creating classes with > private constructors didn't work and I have used objenesis to create > instance of such classe. Additionally I had to add conditional > configuration for surefire and antrun plugins. Let me know if it is good > enough. Especially I would like to ask JB Onofré for checking. > > The last PR is the most important since it blocks updates in other modules > where proxy is used. > > Additionally I see that each commit and rebase generates tons of updates in > related (and even not related) jira. If you know where I can check or > change the configuration then let me know. If you have power to change it, > then please don't hesitate to do it. > > I have some other ideas and problems to solve that I want to discuss - I > will share them in separate messages. > > -- > Regards, > Dominik Przybysz
