+1 (binding)

Tim

> On 23 Feb 2025, at 08:41, Christian Schneider <ch...@die-schneider.net> wrote:
> 
> +1
> Christian
> 
> On Wed, 19 Feb 2025 at 22:25, Dominik Przybysz <alien11...@apache.org>
> wrote:
> 
>> Hello team,
>> 
>> in main repo there is the EJB module.
>> 
>> The module is succesfully compiling and passing all tests with Java 8, but
>> beside that there are really a lot of things that need to be updated.
>> 
>> First, the whole implementation relies on openjb 4.0.0-beta-1 and upgrading
>> to the higher 4.x version is not possible out of the box
>> https://github.com/apache/aries/pull/371
>> There is a comment saying that it's because of the commons lang (
>> 
>> https://github.com/apache/aries/blob/29c4888c787f63c423984dc6cd4472992b2b6602/ejb/ejb-modeller-itest/pom.xml#L74-L75
>> ),
>> but the problem is also the tons of dependencies coming with openejb and
>> openWebBeans.
>> 
>> Apache openejb repo seems to be dead - no changes since 2013 in
>> https://github.com/apache/openejb
>> 
>> There are newer versions of openejb provided by Apache TomEE
>> https://mvnrepository.com/artifact/org.apache.tomee/openejb-core and
>> https://github.com/apache/tomee/tree/main/container/openejb-core
>> We can try to update but the newest version needs Java 17 so we should stay
>> with one of the lower versions or also build with Java 17 - quite a big
>> step.
>> 
>> On our side:
>> - the last release of components from this module was in 2012.
>> - there is no EJB component in jira
>> 
>> https://issues.apache.org/jira/projects/ARIES?selectedItem=com.atlassian.jira.jira-projects-plugin:components-page
>> - there is no entry on our website
>> https://aries.apache.org/documentation/index.html
>> - there is only one usage in production module -
>> application-modeller-standalone - but it looks that the dependency is added
>> to the fat-jar, but there is no usage in the module per se
>> 
>> https://github.com/apache/aries/blob/trunk/application/application-modeller-standalone/pom.xml#L93-L97
>> - there are some usages in samples (outside of the maven reactor): one
>> module in blog and whole aries-trader - both modules should be rewritten
>> when samples are restored in maven reactor
>> - there are 6 security alerts comming from the ejb module
>> 
>> https://github.com/apache/aries/security/dependabot?q=is%3Aopen+manifest%3Aejb%2Fejb-modeller-itest%2Fpom.xml%2Cejb%2Fopenejb-extender-itest%2Fpom.xml
>> 
>> Based on that I propose sending EJB module to the attic. It means:
>> 1. Create tag 'ejb-goes-to-the-attic' on the last commit on trunk (I am
>> open for the better tag name)
>> 2. Remove ejb module, its workflow and the entry in
>> application-modeller-standalone in the following commit
>> 
>> Please vote to approve sending EJB module to the attic as I described
>> above:
>> [ ] +1 Approve
>> [ ] -1 Don't approve
>> 
>> Any -1 means veto (but please give the reason).
>> 
>> This is quite a big cleanup so the vote will be open for at least week and
>> will wait for at least 3 binding +1.
>> 
>> --
>> Regards,
>> Dominik Przybysz
>> 
> 
> 
> -- 
> -- 
> Christian Schneider
> http://www.liquid-reality.de
> 
> Computer Scientist
> http://www.adobe.com

Reply via email to