amichair commented on code in PR #104:
URL: https://github.com/apache/aries-rsa/pull/104#discussion_r3214441239
##########
itests/tck/tck.bndrun:
##########
@@ -17,45 +17,91 @@
# under the License.
#-standalone: target/index.xml
--runtrace = true
+-runtrace: true
--target = \
- org.osgi.test.cases.remoteserviceadmin
+-target: org.osgi.test.cases.remoteserviceadmin
--runproperties = \
- report="true", \
- osgi.resolverMode="strict"
- rsa.ct.timeout="300000", \
- rsa.ct.timeout.factor="3"
-#
org.osgi.test.cases.remoteserviceadmin.system.packages.extra="junit.framework;version=3.8",
\
-#
org.osgi.test.cases.remoteserviceadmin.bundles="jar/osgi.cmpn-5.0.0.jar,jar/org.osgi.impl.service.log-1.3.2.jar,jar/org.apache.cxf.dosgi.singlebundle-1.3.1.jar,jar/org.apache.cxf.dosgi.discovery.server.config-1.2.0.jar",
\
-#
org.osgi.test.cases.remoteserviceadmin.serverconfig="service.exported.configs,org.apache.cxf.ws.port",
\
-# service.exported.configs="org.apache.cxf.ws", \
-# org.apache.cxf.ws.port="@@FREE_PORT@@"
+-runproperties:\
+ report="true",\
+ osgi.resolverMode="strict",\
+ rsa.ct.timeout=30000,\
+ rsa.ct.timeout.factor=3,\
+ rsa.tck.timeout=10000,\
+ service.exported.configs="aries.tcp",\
+ org.osgi.framework.system.packages.extra="\
+ org.osgi.service.remoteserviceadmin",\
+ org.osgi.test.cases.remoteserviceadmin.system.packages.extra="\
+ org.osgi.service.remoteserviceadmin,\
+ junit.framework",\
+
org.osgi.test.cases.remoteserviceadmin.serverconfig="service.exported.configs",\
+ org.osgi.test.cases.remoteserviceadmin.bundles="\
+ ${repo;org.apache.aries.rsa.core;2.0.0.SNAPSHOT},\
+ ${repo;org.apache.aries.rsa.spi;2.0.0.SNAPSHOT},\
+ ${repo;org.apache.aries.rsa.topology-manager;2.0.0.SNAPSHOT},\
+ ${repo;org.apache.aries.rsa.discovery.local;2.0.0.SNAPSHOT},\
+ ${repo;org.apache.aries.rsa.discovery.tcp;2.0.0.SNAPSHOT},\
+ ${repo;org.apache.aries.rsa.provider.tcp;2.0.0.SNAPSHOT},\
+ ${repo;org.osgi.service.component;1.5.1},\
+ ${repo;org.osgi.util.function;1.2.0},\
+ ${repo;org.osgi.util.promise;1.3.0},\
+ ${repo;org.apache.felix.configadmin;1.9.26},\
+ ${repo;org.apache.felix.eventadmin;1.6.4},\
+ ${repo;org.apache.felix.scr;2.2.10},\
+ ${repo;org.apache.servicemix.bundles.junit;4.13.2},\
+ ${repo;org.ops4j.pax.logging.pax-logging-api;2.2.7},\
+ ${repo;org.ops4j.pax.logging.pax-logging-log4j2;2.2.7},\
+ ${repo;jakarta.activation-api;2.1.4},\
+ ${repo;jakarta.xml.bind-api;4.0.5},\
+ ${repo;com.sun.xml.bind.jaxb-impl;4.0.5},\
+ ${repo;com.sun.xml.bind.jaxb-core;4.0.5},\
+ ${repo;com.sun.istack.commons-runtime;4.1.2},\
+ ${repo;org.glassfish.hk2.osgi-resource-locator;3.0.0}",\
+ org.apache.aries.rsa.discovery.tcp.address=localhost:7668,\
+ org.apache.aries.rsa.discovery.tcp.peers=localhost:7669,\
+ org.apache.aries.rsa.bridge=true,\
Review Comment:
I explained this at length in the JIRA - bottom line is that this is here
basically just for the TCK and is extremely unlikely to ever be needed in real
systems. The configuration option is left for those cases. Running it by
default on all other systems that don't need it is just unnecessary runtime
complexity and performance degradation (all endpoint events pass through the
bridge, which also becomes a SPOF). I think it's better to leave it off (even
though I spent quite some time figuring out how to do this thing with the hooks
and all :-) ).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
