alien11689 commented on code in PR #109:
URL: https://github.com/apache/aries-rsa/pull/109#discussion_r3235451788
##########
provider/tcp/src/test/java/org/apache/aries/rsa/provider/tcp/TcpProviderIntentTest.java:
##########
@@ -51,10 +50,16 @@ public void before() {
myService = new MyServiceImpl(null);
}
+ private Map<String, Object> createProps() {
+ Map<String, Object> props = new HashMap<>();
+ String[] names =
Arrays.stream(exportedInterfaces).map(Class::getName).toArray(String[]::new);
+ props.put(org.osgi.framework.Constants.OBJECTCLASS, names);
Review Comment:
nitpicking: let's import instead of using FQN, also in other places in the PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
