alien11689 commented on code in PR #110:
URL: https://github.com/apache/aries-rsa/pull/110#discussion_r3244069101
##########
topology-manager/src/main/java/org/apache/aries/rsa/topologymanager/exporter/TopologyManagerExport.java:
##########
@@ -87,40 +87,31 @@ private String getTypeName(ServiceEvent event) {
public void serviceChanged(ServiceEvent event) {
ServiceReference<?> sref = event.getServiceReference();
if (!shouldExport(sref)) {
- LOG.trace("Skipping service {}", sref);
+ LOG.trace("ignoring service {}", sref);
return;
}
LOG.info("Received ServiceEvent type: {}, sref: {}",
getTypeName(event), sref);
switch (event.getType()) {
case ServiceEvent.REGISTERED:
- add(sref);
+ exportable.add(sref);
+ export(sref);
break;
case ServiceEvent.MODIFIED:
- modified(sref);
+ // TODO: we should determine whether the properties that changed
are normal
Review Comment:
if TODO is going to be fixed in the future then it should have jira-id
assigned (e.g. `TODO ARIES-ZYX`), if not then there is no point to create TODO
comment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
