amichair commented on code in PR #118:
URL: https://github.com/apache/aries-rsa/pull/118#discussion_r3295381654
##########
discovery/zookeeper/pom.xml:
##########
@@ -95,16 +87,51 @@
<artifactId>mockito-core</artifactId>
<scope>test</scope>
</dependency>
- <dependency>
- <groupId>org.hamcrest</groupId>
- <artifactId>hamcrest-all</artifactId>
- <scope>test</scope>
- </dependency>
+
<dependency>
<groupId>org.apache.felix</groupId>
<artifactId>org.apache.felix.converter</artifactId>
<scope>test</scope>
</dependency>
</dependencies>
+ <build>
+ <plugins>
+ <!--
+ ZooKeeper artifacts have no OSGi support, and the two
inter-dependent bundles
+ (zookeeper and zookeeper-jute) make them difficult to just
wrap, so we embed
+ them into our discovery bundle
+ -->
+ <plugin>
+ <groupId>org.apache.felix</groupId>
+ <artifactId>maven-bundle-plugin</artifactId>
Review Comment:
ok, I think I managed to do it another way, is there a
better/shorter/cleaner way than this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
