amichair commented on PR #59: URL: https://github.com/apache/aries-rsa/pull/59#issuecomment-4561140252
The suggested changes create a race condition between all processed events by dispatching each one to be individually processed in a separate thread, which may result in the events being processed out of order, i.e. an endpoint that is added and then immediately removed may end up first processing the remove (no-op) and then the addition (importing a service that should no longer exist), and vice versa. The race seems to be inherent to the design in the PR (if I understood the description correctly, which admittedly, I'm not sure I did). So I think the PR should not be accepted at this point. This did bring to my attention a different race condition in the existing implementation, so thanks for that. It seems like an easy fix and will be applied in a separate PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
