amichair commented on code in PR #119:
URL: https://github.com/apache/aries-rsa/pull/119#discussion_r3315832074
##########
provider/fastbin/src/main/java/org/apache/aries/rsa/provider/fastbin/FastBinProvider.java:
##########
@@ -50,6 +57,8 @@ public class FastBinProvider implements DistributionProvider {
private static final Logger LOG =
LoggerFactory.getLogger(FastBinProvider.class);
+ static final String[] SUPPORTED_INTENTS = { "tck.test" }; // at least one
intent required by TCK
Review Comment:
Hmmm... the field itself is not the default empty intents, but all currently
supported intents (if we wanted to add one, we would just add it to this array,
not rename the array or add another array), so I think it's current name is
correct. It just so happens that we currently support only one dummy intent,
necessary for the TCK but a no-op otherwise. I'm not even sure it should be in
a javadoc - it's an internal implementation detail that should not be
public-facing and may be removed in the future if they fix the TCK test. There
is no way to make the distinction between a 'public javadoc' and 'private
javadoc', so we either consider the whole javadoc private or separate the
public javadoc (just "All intents supported by this provider" and an
implementation-detail comment similar to the existing one just so maintainers
won't remove this unintuitive no-op string. What do you prefer?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
