alien11689 commented on code in PR #140:
URL: https://github.com/apache/aries-rsa/pull/140#discussion_r3374660777
##########
rsa/src/main/java/org/apache/aries/rsa/core/RemoteServiceAdminCore.java:
##########
@@ -504,23 +504,22 @@ protected void
removeExportRegistration(ExportRegistration eri) {
}
protected void removeImportRegistration(ImportRegistration iri) {
- synchronized (importedServices) {
- LOG.debug("Removing importRegistration {}", iri);
-
- ImportReference importRef = iri.getException() != null ? null :
iri.getImportReference();
- if (importRef == null) {
- return;
+ LOG.debug("Removing importRegistration {}", iri);
+ ImportReference importRef = iri.getException() != null ? null :
iri.getImportReference();
Review Comment:
can we rename `iri` to something more meaningful? it's not a good acronym
for `Import Registration`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
