[ https://issues.apache.org/jira/browse/ARROW-187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15372255#comment-15372255 ]
Micah Kornfield commented on ARROW-187: --------------------------------------- based on conversation on the mailing list the consensus seems to be that unguarded allocations are fine for metadata but should be required to all file handle/data allocations. This is the pattern we currently use in the code base. I will update documentation to reflect this and then close this issue. > [C++] Decide on how pedantic we want to be about exceptions > ----------------------------------------------------------- > > Key: ARROW-187 > URL: https://issues.apache.org/jira/browse/ARROW-187 > Project: Apache Arrow > Issue Type: Bug > Components: C++ > Reporter: Micah Kornfield > > We currently have code sprinkled around constructors that can technically > fail because we either do a memcpy/allocation via vector copy constructor (we > might be using a move constructor in places) and make_shared<>. > These are very small memory allocations but they can throw std::bad_alloc. > Technically, we would need to convert these to use Init or static factories. > (types.h is one place to look) -- This message was sent by Atlassian JIRA (v6.3.4#6332)