-1 (non-binding)

I get an error when running js-verify-release-candidate.sh, which
I can also replicate with a fresh clone of arrow on commit
17b09ca0676995cb62ea1f9b6d6fa2afd99c33c6 by running `npm install`
and then `npm run test -- -t ts`:

[10:21:08] Starting 'test:ts'...
‚óŹ Validation Error:

  Module ./node_modules/babel-jest/build/index.js in the transform option was 
not found.

  Configuration Documentation:
  https://facebook.github.io/jest/docs/configuration.html

[10:21:09] 'test:ts' errored after 306 ms
[10:21:09] Error: exited with error code: 1
    at ChildProcess.onexit 
(/tmp/arrow/js/node_modules/end-of-stream/index.js:39:36)
    at emitTwo (events.js:126:13)
    at ChildProcess.emit (events.js:214:7)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:198:12)
[10:21:09] 'test' errored after 311 ms


Seems like the issue is that babel-jest is not included as a dev
dependency, so it's not found in node_modules in the new clone.
Not sure how it was working in the past, perhaps it was a
transitive dependency that was reliably included?

I can put up a PR to add the dependency

Brian


On 03/10/2018 01:52 PM, Wes McKinney wrote:
+1 (binding), ran js-verify-release-candidate.sh with NodeJS 8.10.0
LTS on Ubuntu 16.04

On Sat, Mar 10, 2018 at 1:52 PM, Wes McKinney <wesmck...@gmail.com> wrote:
Hello all,

I'd like to propose the 1st release candidate (rc0) of Apache Arrow
JavaScript version 0.3.0.  This is a bugfix release from 0.3.0.

The source release rc0 is hosted at [1].

This release candidate is based on commit
17b09ca0676995cb62ea1f9b6d6fa2afd99c33c6

Please download, verify checksums and signatures, run the unit tests, and vote
on the release. The easiest way is to use the JavaScript-specific release
verification script dev/release/js-verify-release-candidate.sh.

The vote will be open for at least 24 hours and will close once
enough PMCs have approved the release.

[ ] +1 Release this as Apache Arrow JavaScript 0.3.1
[ ] +0
[ ] -1 Do not release this as Apache Arrow JavaScript 0.3.1 because...

Thanks,
Wes

How to validate a release signature:
https://httpd.apache.org/dev/verification.html

[1]: https://dist.apache.org/repos/dist/dev/arrow/apache-arrow-js-0.3.1-rc0/
[2]: 
https://github.com/apache/arrow/tree/17b09ca0676995cb62ea1f9b6d6fa2afd99c33c6

Reply via email to