Thanks. I will do that on a few hours and then i have a small PR (about support for logical vectors) ready to go and associated with a jira issue i opened this morning.
Romain > Le 27 sept. 2018 à 18:46, Wes McKinney <[email protected]> a écrit : > > I checked out your branch and ran r/lint.sh and it printed the following > > https://gist.github.com/wesm/42f1682565ac9737fecc60d12a15927e > > You can run > > ./lint.sh --fix > > to fix the problems >> On Thu, Sep 27, 2018 at 9:46 AM Romain François <[email protected]> wrote: >> >> I don’t think that’s just that. I sent a new build anyway that is ahead of >> the upstream repo. >> >> In any case, there’s probably something i should be doing. >> >> Romain >> >>> Le 27 sept. 2018 à 13:19, Wes McKinney <[email protected]> a écrit : >>> >>> Looks like you need to rebase your branch >>>> On Thu, Sep 27, 2018 at 7:18 AM Wes McKinney <[email protected]> wrote: >>>> >>>> hi Romain, >>>> >>>> I just put this in the README >>>> https://github.com/apache/arrow/tree/master/r#development >>>> >>>> - Wes >>>>> On Thu, Sep 27, 2018 at 7:17 AM Romain François <[email protected]> >>>>> wrote: >>>>> >>>>> Hello, >>>>> >>>>> Is there documentation about what i should be doing to make clang-format >>>>> happy? E.g to make this build pass: >>>>> https://travis-ci.org/romainfrancois/arrow/builds/434027141 >>>>> >>>>> Romain >>
