rustfmt will hit 1.0 tomorrow (Rust 1.31 release) and ensures stable formatting over multiple releases. As far as I understood, this "formatting style stability" will affect all channels, so we could run rustfmt on the same channel(s) as our CI. Might be that we need a jira ticket to change from "rustfmt preview" to normal rustfmt in our CI scripts.
Reference: https://www.ncameron.org/blog/rustfmt-1-rc/ On December 5, 2018 6:55:40 AM GMT+01:00, Chao Sun <sunc...@apache.org> wrote: >One question is whether we should only restrict this on rustfmt but >still >use nightly for testing. Also, how often should we update the nightly >version? does it require a JIRA every time? > >Another option is to run stable rustfmt but use nightly for CI. Since >we're >already running CI with stable, this should be an easy change. > >On Tue, Dec 4, 2018 at 8:54 PM Andy Grove <andygrov...@gmail.com> >wrote: > >> One of the challenges of using Rust nightly is that things can change >> often. Master builds have been failing because CI is picking up the >latest >> nightly all the time, and the formatting rules change over time. >> >> One option to avoid this is to have CI use a specific nightly version >> rather than always using the latest, and then we can use PRs to >update the >> nightly version being used. For example we can have the CI script run >the >> following command: >> >> rustup default nightly-2018-12-05 >> >> If there are no objections I will create a JIRA issue for this. >> >> Andy. >>
