I commented on ARROW-4383. I think it would be ideal to use the installed .cmake files if they exist, but since some packages have non-CMake build systems we can't always assume that they'll be there. We need to support the ones that do, though
On Sun, Feb 3, 2019 at 12:27 AM Suvayu Ali <[email protected]> wrote: > > Hi Javier, > > On Sat, Feb 02, 2019 at 11:52:10AM -0800, Javier Luraschi wrote: > > Thanks for the additional info, it's really helpful to hear your thoughts > > and potential > > issues we might need to resolve. > > > > The R package is planning to support feature flags, so a start, I'm hoping > > we can > > support a minimal version of Arrow with the minimum set of dependencies. It > > seems > > to be the case that: protobuf > > <https://apps.fedoraproject.org/packages/protobuf>, boost > > <https://apps.fedoraproject.org/packages/boost> and double-conversion > > <https://apps.fedoraproject.org/packages/double-conversion> are already > > available, > > wouldn't this simplify the initial submission? > > AFAIK, Fedora provides all of Arrow's dependencies except one: Re2 (kind of). > For whatever reason, Re2 seems abandoned. There seems to be an automated > release for every new version of Fedora, although the available package > version is from 2016![1] I just opened a bug asking to update the version, > now we need to find someone to look into it. > > Besides the above, you will probably also have trouble with Thrift, jemalloc, > snappy, etc (not sure how critical they are as dependencies, the last two > are probably critical). Personally, I have tried using the system Thrift, > and failed miserably. On the other hand, I managed to use the system LLVM > (for Gandiva) with a one line patch (merged in master). > > That said, as Kou pointed out, resolving ARROW-4383 probably will make this > a lot easier. > > I hope this helps. > > Cheers, > > > [1] https://apps.fedoraproject.org/packages/re2/changelog > > -- > Suvayu > > Open source is the future. It sets us free.
