Just to clarify, the current pom under java/format is downloading it for linux/osx and fails for windows since there is no pre-packaged artifact or is not attempting to look for the standard binary in the path either from what I could see. I'd be happy to contribute with a fix in the same way that's been done for those other OSes - i.e. prepackaging flatc in that maven repo that seems to have been introduced for arrow only (though I might be wrong here?)
In any case, I agree and is fairly easy to work out with the provided error messages/failures so it is not a big deal either On Sat, 2 Mar 2019 at 21:22, Wes McKinney <wesmck...@gmail.com> wrote: > I would be sort of inclined to expect Java users to have flatc > installed on their system rather than try to maintain an automatic > download. This project is intended for intermediate to advanced > developers; to require a system-level package be installed in addition > to the JDK does not seem unreasonable. > > If there turns out to be a dependable, maintained (preferably not by > the Arrow community) Maven artifact, then we could use this, but there > does not seem to be one right now. > > On Sat, Mar 2, 2019 at 5:18 AM Sebastian Piu <sebastian....@gmail.com> > wrote: > > > > Doing mvn install on arrow/java fails on a windows machine due to no > > suitable dependency available for flatc in maven central: > > com.github.icexelloss:flatc-windows-x86_64:exe:1.9.0 in central ( > > https://repo.maven.apache.org/maven2) > > > > The solution from reading the pom is: > > > > 1) manually download flatc 1.9.0 from > > https://github.com/google/flatbuffers/releases > > 2) extract and rename flatc.exe to > > java/format/target/flatc-windows-x86_64-1.9.0.exe > > 3) run mvn install -Dflatc.download.skip=true > > > > Would there be interest on fixing this by publishing the binary from here > > <https://github.com/icexelloss/flatc>? or at least adding a readme > entry on > > how to get past this? Any other thoughts? >
