I opened https://issues.apache.org/jira/browse/ARROW-5091
On Tue, Apr 2, 2019 at 9:53 AM ming zhang <ming.zhang.ch...@gmail.com> wrote: > > it is not a big deal for sure. it is just help new comer to build a mental > model quicker. code is for reader anyway. > > i will submit a patch later > > thanks > ming > > > On Tue, Apr 2, 2019 at 10:14 AM Wes McKinney <wesmck...@gmail.com> wrote: > > > I don't have a problem with the name personally but writing a patch > > would be the next step. > > > > On Tue, Apr 2, 2019 at 8:59 AM ming zhang <ming.zhang.ch...@gmail.com> > > wrote: > > > > > > looks like we are ok with FlighInfo. what is the next step? should I > > write > > > a proposal or submit a patch? i just start working around Arrow Flight > > and > > > need to learn the procedure here. thanks > > > > > > > > > > > > > > > On Tue, Apr 2, 2019 at 9:48 AM Antoine Pitrou <anto...@python.org> > > wrote: > > > > > > > > > > > Oh, you're right. The corresponding method is already named > > GetFlightInfo. > > > > > > > > Regards > > > > > > > > Antoine. > > > > > > > > > > > > Le 02/04/2019 à 15:37, Wes McKinney a écrit : > > > > > FlightGetInfo is a message so if we are going to change the name, we > > > > > should make it more noun-like, such as FlightInfo. > > > > > > > > > > On Tue, Apr 2, 2019 at 7:08 AM Antoine Pitrou <anto...@python.org> > > > > wrote: > > > > >> > > > > >> > > > > >> If we change it, I vote for GetFlightInfo. > > > > >> > > > > >> Regards > > > > >> > > > > >> Antoine. > > > > >> > > > > >> > > > > >> Le 02/04/2019 à 14:07, ming zhang a écrit : > > > > >>> Hi > > > > >>> > > > > >>> The name of FlightGetInfo is kind of strange. It is a > > noun+verb+noun, > > > > which > > > > >>> is not consistent with others like FlightData, FlightDescriptor, > > etc. > > > > The > > > > >>> 1st impression is that this is a method, not a message, since other > > > > methods > > > > >>> are verb+noun. > > > > >>> > > > > >>> Should FlightGetInfo to be FlightInfo? > > > > >>> > > > > >>> Thanks > > > > >>> Ming > > > > >>> > > > > > >
