I believe reader/writer indexes are typically used when we send buffers over the wire -- so may not be necessary for all users of ArrowBuf. I am okay with the idea of providing a simple wrapper to ArrowBuf to manage the reader/writer indexes with a couple of APIs. Note that some APIs like writeInt, writeLong() bump the writer index unlike setInt/setLong counterparts. JsonFileReader uses some of these APIs.
On Sat, Apr 13, 2019 at 2:42 PM Jacques Nadeau <jacq...@apache.org> wrote: > Hey Sidd, > > Thanks for pulling this together. This looks very promising. One quick > thought: do we think the concept of the reader and writer index need to be > on ArrowBuf? It seems like something that could be added as an additional > decoration/wrapper when needed instead of being part of the core structure. > > On Sat, Apr 13, 2019 at 11:26 AM Siddharth Teotia <siddha...@dremio.com> > wrote: > > > Hi All, > > > > I have put a PR with WIP changes. All the major set of changes have been > > done to decouple the usage of ArrowBuf and reference management. The > > ArrowBuf interface is much simpler and clean now. > > > > I believe there would be several folks in the community interested in > these > > changes so please feel free to take a look at the PR and provide your > > feedback -- https://github.com/apache/arrow/pull/4151 > > > > There is some cleanup needed (code doesn't compile yet) due to moving the > > APIs but I have raised the PR to get an early feedback from the community > > on the critical changes. > > > > Thanks, > > Siddharth > > >
