I note that a change from underscores to hyphens would significantly affect the Parquet, Plasma, and Gandiva libraries so I think we need to hear from other developers of those subprojects. Underscores are definitely less disruptive to the status quo
On Tue, Aug 6, 2019 at 4:18 PM Wes McKinney <wesmck...@gmail.com> wrote: > > I have a slight gut preference for underscores but I am OK with > changing everything to hyphens. The hyphens will probably grow on me > as it means pressing the "shift" key less frequently. Is there any > technical argument for using one over the other? My understanding is > that `git blame` is pretty robust to renames > > On Tue, Aug 6, 2019 at 7:04 AM Antoine Pitrou <solip...@pitrou.net> wrote: > > > > > > Hello, > > > > The filenames in the C++ source tree are a bit ad hoc and inconsistent. > > Sometimes they use hyphens for word separation, sometimes underscores. > > In ARROW-4648 it was proposed that we unify C++ file naming, therefore > > there are two possible options: only hyphens, or only underscores. > > > > What are your preferences? Personally, I have a slight preference for > > hyphens, especially as they are already used in binary names. > > > > Regards > > > > Antoine. > > > >
